Add migration code for f32/f64.
#1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `WIT_REQUIRE_F32_F64` environment variable controlling whether the `float32` and `float64` syntax is acccepted, similar to the transition for semicolons.
5 tasks
sunfishcode
added a commit
to sunfishcode/wasm-tools
that referenced
this pull request
Mar 21, 2024
Following up on bytecodealliance#1364 which added `f32` and `f64` parsing support, this PR renames the types `float32` and `float64` to `f32` and `f64`. The old names are still accepted for now. WebAssembly/component-model#277
sunfishcode
added a commit
to sunfishcode/wasm-tools
that referenced
this pull request
Mar 21, 2024
As discussed [here], and following up on bytecodealliance#1364 which added `f32` and `f64` parsing support, this PR renames the types `float32` and `float64` to `f32` and `f64`. The old names are still accepted by the parser for compatibility. [here]: WebAssembly/component-model#277
sunfishcode
added a commit
to sunfishcode/wasm-tools
that referenced
this pull request
Mar 21, 2024
As discussed [here], and following up on bytecodealliance#1364 which added `f32` and `f64` parsing support, this PR renames the types `float32` and `float64` to `f32` and `f64`. The old names are still accepted by the parser for compatibility. [here]: WebAssembly/component-model#277
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
As discussed [here], and following up on #1364 which added `f32` and `f64` parsing support, this PR renames the types `float32` and `float64` to `f32` and `f64`. The old names are still accepted by the parser for compatibility. [here]: WebAssembly/component-model#277
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Sep 11, 2024
This commit continues the transition started in bytecodealliance#1364 to rename the `float32 `and `float64` types in WIT to `f32` and `f64`. Now that support has been present for some time to parse `f32` and `f64` this commit flips the WIT parser to requiring it by default. The error message for `float32` and `float64` has additionally been updated to explain a bit more about this transition.
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Sep 12, 2024
This commit continues the transition started in bytecodealliance#1364 to rename the `float32 `and `float64` types in WIT to `f32` and `f64`. Now that support has been present for some time to parse `f32` and `f64` this commit flips the WIT parser to requiring it by default. The error message for `float32` and `float64` has additionally been updated to explain a bit more about this transition.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
This commit continues the transition started in #1364 to rename the `float32 `and `float64` types in WIT to `f32` and `f64`. Now that support has been present for some time to parse `f32` and `f64` this commit flips the WIT parser to requiring it by default. The error message for `float32` and `float64` has additionally been updated to explain a bit more about this transition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
WIT_REQUIRE_F32_F64environment variable controlling whether thefloat32andfloat64syntax is acccepted, similar to the transition for semicolons.