Remove old syntax for core wasm instructions #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long ago instructions like `get_local` were renamed to `local.get` along with a number of other instructions. The `wast` crate has for quite some time supported parsing the old forms but `wasmprinter` has always printed out the most "up to date" forms. This commit goes through and deletes the parsing support for all the old forms, meaning that it's now an error to use such syntax. Closes bytecodealliance#1164
pchickey
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long ago instructions like
get_localwere renamed tolocal.getalong with a number of other instructions. Thewastcrate has for quite some time supported parsing the old forms butwasmprinterhas always printed out the most "up to date" forms.This commit goes through and deletes the parsing support for all the old forms, meaning that it's now an error to use such syntax.
Closes #1164