Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future of old syntax for local.get or global.set #1164

Closed
yurydelendik opened this issue Aug 14, 2023 · 1 comment · Fixed by #1184
Closed

Future of old syntax for local.get or global.set #1164

yurydelendik opened this issue Aug 14, 2023 · 1 comment · Fixed by #1184
Labels
good first issue Good for newcomers

Comments

@yurydelendik
Copy link
Contributor

Currently, two versions of syntax for some instructions exist, e.g.local.get and get_local. Is there a plan to phase out the latter version?

See also WebAssembly/spec#884
@yurydelendik yurydelendik changed the title Old syntax for local.get or global.set? Future of old syntax for local.get or global.set Aug 14, 2023
@alexcrichton
Copy link
Member

I don't believe any plans exist yet to phase out the old syntax, but it hasn't been the primary syntax in so long I think it'd be fine to delete all the old syntax at any time now. Would you be up for sending a PR to delete the old syntax?

@yurydelendik yurydelendik added the good first issue Good for newcomers label Aug 18, 2023
alexcrichton added a commit to alexcrichton/wasm-tools that referenced this issue Aug 25, 2023
@alexcrichton
Remove old syntax for core wasm instructions
a57e654 
Long ago instructions like `get_local` were renamed to `local.get` along
with a number of other instructions. The `wast` crate has for quite some
time supported parsing the old forms but `wasmprinter` has always
printed out the most "up to date" forms.

This commit goes through and deletes the parsing support for all the old
forms, meaning that it's now an error to use such syntax.

Closes bytecodealliance#1164
@alexcrichton alexcrichton mentioned this issue Aug 25, 2023
Merged
alexcrichton added a commit that referenced this issue Aug 25, 2023
@alexcrichton
Remove old syntax for core wasm instructions (#1184)
8bf2677 
Long ago instructions like `get_local` were renamed to `local.get` along
with a number of other instructions. The `wast` crate has for quite some
time supported parsing the old forms but `wasmprinter` has always
printed out the most "up to date" forms.

This commit goes through and deletes the parsing support for all the old
forms, meaning that it's now an error to use such syntax.

Closes #1164
@keithw keithw mentioned this issue Sep 20, 2023
Merged
@alexcrichton alexcrichton mentioned this issue Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove old syntax for core wasm instructions alexcrichton/wasm-tools
2 participants
@alexcrichton @yurydelendik