Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wkg)!: Adds support for pushing and pulling OCI wasm artifacts #44

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

thomastaylor312
Copy link
Collaborator

This adds support for pushing and pulling compatible OCI wasm artifacts from the command line. As part of this refactor, it makes the original loading feature a separate command for use in debugging. Some of the features from the load subcommand should probably make their way into the push and pull command, but for now just keeping it simple

crates/wkg/src/oci.rs Outdated Show resolved Hide resolved
crates/wkg/src/main.rs Outdated Show resolved Hide resolved
crates/wkg/src/main.rs Outdated Show resolved Hide resolved
crates/wkg/src/main.rs Outdated Show resolved Hide resolved
@yoshuawuyts
Copy link
Member

Oh by the way, I tried this out today with a colleague and it seems to work really well.

It's really nice to be able to push and pull .wasm files directly to an OCI registry. I don't have any concrete nits or anything on this PR, but figured it would still be useful to share that: "I tried this and it worked well!"

This adds support for pushing and pulling compatible OCI wasm artifacts
from the command line. As part of this refactor, it makes the original
loading feature a separate command for use in debugging. Some of the
features from the `load` subcommand should probably make their way into
the push and pull command, but for now just keeping it simple

Signed-off-by: Taylor Thomas <[email protected]>
@thomastaylor312 thomastaylor312 merged commit 7e2d63a into bytecodealliance:main Jun 24, 2024
1 check passed
@thomastaylor312 thomastaylor312 deleted the feat/wkg_oci branch June 24, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants