-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wkg)!: Adds support for pushing and pulling OCI wasm artifacts #44
Merged
thomastaylor312
merged 1 commit into
bytecodealliance:main
from
thomastaylor312:feat/wkg_oci
Jun 24, 2024
Merged
feat(wkg)!: Adds support for pushing and pulling OCI wasm artifacts #44
thomastaylor312
merged 1 commit into
bytecodealliance:main
from
thomastaylor312:feat/wkg_oci
Jun 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
reviewed
Jun 17, 2024
d8176a0
to
5940af6
Compare
lann
reviewed
Jun 18, 2024
5940af6
to
2a52302
Compare
lann
reviewed
Jun 18, 2024
2a52302
to
270173e
Compare
calvinrp
reviewed
Jun 18, 2024
8f3105d
to
573e8ce
Compare
Oh by the way, I tried this out today with a colleague and it seems to work really well. It's really nice to be able to push and pull |
This adds support for pushing and pulling compatible OCI wasm artifacts from the command line. As part of this refactor, it makes the original loading feature a separate command for use in debugging. Some of the features from the `load` subcommand should probably make their way into the push and pull command, but for now just keeping it simple Signed-off-by: Taylor Thomas <[email protected]>
573e8ce
to
744ced0
Compare
calvinrp
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for pushing and pulling compatible OCI wasm artifacts from the command line. As part of this refactor, it makes the original loading feature a separate command for use in debugging. Some of the features from the
load
subcommand should probably make their way into the push and pull command, but for now just keeping it simple