Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid event loop interest bump #185

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Dec 9, 2024

There are two problems with this event loop interest management for the new blob StreamTask implementation:

  1. I'm not seeing where non-cancelled stream tasks are getting their interest decremented
  2. Event loop interest is purely about the request / response lifecycle requirements and not arbitrary immediate tracking

//cc @andreiltd

@guybedford
Copy link
Contributor Author

Strangely the WPT cases are passing here but failed for me locally. Will need some further investigation before landing.

@guybedford
Copy link
Contributor Author

Can confirm the WPT are passing for me locally so it was a local build issue. In this case this should be okay to land as-is.

@guybedford guybedford merged commit f957cd4 into main Dec 10, 2024
5 checks passed
@guybedford guybedford deleted the remove-interest branch December 10, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants