Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible incorrect event loop interest for blob implementation #186

Closed
guybedford opened this issue Dec 9, 2024 · 5 comments
Closed

Possible incorrect event loop interest for blob implementation #186

guybedford opened this issue Dec 9, 2024 · 5 comments

Comments

@guybedford
Copy link
Contributor

The new immediate steam tasks always increase event loop interest.

I believe this is incorrect, because event loop interest is purely about the request / response lifecycle, and if one happened to be constructing blobs on immediate tasks in a recursive loop that are entirely irrelevant to the request / response lifecycle, these blob immediates should not drive interest at all.

Posted #185.

//cc @andreiltd

@andreiltd
Copy link
Contributor

Is this fixed by #185 or does it require further investigation?

@guybedford
Copy link
Contributor Author

Resolved, thanks. Although I am getting a really strange error when trying to use this stuff in Fastly's build here - fastly/js-compute-runtime#1070. A completely unrelated test case is failing even when none of the added code paths in that PR actually run for it. And it only happens in the release build not the debug build. Spent ages bisecting it and still can't figure it out...

@andreiltd
Copy link
Contributor

That sounds awful. Do you have a minimal JS script that could reproduce the bug in StarlingMonkey? If so, I can take a look as well. :)

@guybedford
Copy link
Contributor Author

Yeah already spent 5 hours on it adding abort() statements into the extract_body blob path, and it randomly breaks inly on the stream ops, but again these are dead code paths! Unfortunately there's no minimal replication, and it also requires a Fastly API key to test. Perhaps we can arrange a pairing session on it sometime?

@andreiltd
Copy link
Contributor

andreiltd commented Dec 10, 2024

Perhaps we can arrange a pairing session on it sometime?

Yeah sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants