-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible incorrect event loop interest for blob implementation #186
Comments
Is this fixed by #185 or does it require further investigation? |
Resolved, thanks. Although I am getting a really strange error when trying to use this stuff in Fastly's build here - fastly/js-compute-runtime#1070. A completely unrelated test case is failing even when none of the added code paths in that PR actually run for it. And it only happens in the release build not the debug build. Spent ages bisecting it and still can't figure it out... |
That sounds awful. Do you have a minimal JS script that could reproduce the bug in StarlingMonkey? If so, I can take a look as well. :) |
Yeah already spent 5 hours on it adding |
Yeah sure! |
The new immediate steam tasks always increase event loop interest.
I believe this is incorrect, because event loop interest is purely about the request / response lifecycle, and if one happened to be constructing blobs on immediate tasks in a recursive loop that are entirely irrelevant to the request / response lifecycle, these blob immediates should not drive interest at all.
Posted #185.
//cc @andreiltd
The text was updated successfully, but these errors were encountered: