Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed eslint warning #378

Merged
merged 2 commits into from
Oct 29, 2017
Merged

Fixed eslint warning #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb54ec1
added [app]: yarn.lock file
snhasani Oct 29, 2017
a08b8d0
Fixed [app -> eslint]: set false jsx-use-if-tag rule
snhasani Oct 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
{
"parser": "babel-eslint",
"plugins": [
"jsx-control-statements"
],
"plugins": ["jsx-control-statements"],
"extends": [
"standard",
"standard-react",
"plugin:jsx-control-statements/recommended",
"prettier"
],
"ecmaFeatures": {
"jsx": true
},
"env": {
"node": true,
"browser": true,
Expand All @@ -18,6 +19,7 @@
"semi": ["error", "always"],
"space-before-function-paren": ["error", "never"],
"jsx-quotes": "off",
"comma-dangle": "off"
"comma-dangle": "off",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this violates the prettier config. I would suggest having comma-dangle as a violation.

@sallar?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perry-mitchell I think those already existed in .eslintrc before prettier era.. I have added "prettier" preset so all these extra overrides should be removed from here including this one. But I think this changed was not made by @snhasani

Copy link
Member

@perry-mitchell perry-mitchell Oct 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point! My mistake. It's fine with me then..

"jsx-control-statements/jsx-use-if-tag": 0
}
}
Loading