Fixed eslint warning #378
Merged
Fixed eslint warning #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,6 +19,7 @@ | |||
| "semi": ["error", "always"], | |||
| "space-before-function-paren": ["error", "never"], | |||
| "jsx-quotes": "off", | |||
| "comma-dangle": "off" | |||
| "comma-dangle": "off", | |||
There was a problem hiding this comment.
I think this violates the prettier config. I would suggest having comma-dangle as a violation.
There was a problem hiding this comment.
@perry-mitchell I think those already existed in .eslintrc before prettier era.. I have added "prettier" preset so all these extra overrides should be removed from here including this one. But I think this changed was not made by @snhasani
There was a problem hiding this comment.
Ah good point! My mistake. It's fine with me then..
perry-mitchell
approved these changes
Oct 29, 2017
sallar
approved these changes
Oct 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These eslint warnings should be resolved:
and also I added
yarn.lockfile. Because I could not install npm packages with Iran's Internet, but Yarn did it!