Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username Prefix && housekeeping #9

Merged
merged 7 commits into from Dec 8, 2018
Merged

Username Prefix && housekeeping #9

merged 7 commits into from Dec 8, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 7, 2018

This PR contains two things (sorry for mixing, housekeeping in that size wasn't intended initially)

  • support to add prefixes to the looked up usernames to distinguish between multiple accounts.
  • some housekeeping
    • the input/output is now generated from the terraform code by terraform-docs
    • the zip file is build from scratch (to prevent old files staying in it)
    • binary files (.pyc) are removed to reduce the size to a half of it

Jonathan and others added 7 commits March 11, 2018 12:34
With this change, it's easier to update the README. All you have
to do is run terraform-docs md module and copy/paste the output.
Useful in situations where multiple deployments of this lambda in different accounts
report to the same slack channel.
@builtinnya builtinnya self-requested a review December 8, 2018 00:59
Copy link
Owner

@builtinnya builtinnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your PR!

@builtinnya builtinnya merged commit 06187a0 into builtinnya:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants