Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to set default emoji #2

Merged
merged 1 commit into from
Jan 19, 2018

Conversation

umisora
Copy link
Contributor

@umisora umisora commented Jan 19, 2018

About

I want to change the emoji because default emoji is not cool.

Change to

Changed lambda to accept env of default_emoji.

How to use

Specify default_emoji in your terraform code

module "sns_to_slack" {
  source = "github.com/xxxxxxx/aws-sns-slack-terraform/module"

  slack_webhook_url = "hooks.slack.com/services/xxxxxxxx/xxxxxxxx"
  slack_channel_map = "{ \"topic-name\": \"#slack-channel\" }"
  default_emoji     = ":tada:"  ← New
}

* You can set default emoji
@umisora
Copy link
Contributor Author

umisora commented Jan 19, 2018

Sample Slack UI ( in my project )

image

@umisora
Copy link
Contributor Author

umisora commented Jan 19, 2018

@builtinnya
Thank you for your aws-sns-slack-terraform.
Please review this PR.

Copy link
Owner

@builtinnya builtinnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
LGTM 👍

@builtinnya builtinnya merged commit dcd76d1 into builtinnya:master Jan 19, 2018
@umisora
Copy link
Contributor Author

umisora commented Jan 19, 2018

Thank you for your review!

@umisora umisora deleted the set_default_emoji branch January 19, 2018 07:23
builtinnya pushed a commit that referenced this pull request Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants