Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable -Wundef and fix warnings #1438

Merged
merged 2 commits into from
Jul 18, 2022
+14 −15
Merged

Enable -Wundef and fix warnings #1438

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ddab23
Enable -Wundef and fix warnings
nickdowell Jul 18, 2022
a5b197c
Fix use of TARGET_OS_MACCATALYST with older SDKs
nickdowell Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix use of TARGET_OS_MACCATALYST with older SDKs
@nickdowell
nickdowell committed Jul 18, 2022
commit a5b197c51272e29b952c451eb39c98f1d4699841
2 changes: 1 addition & 1 deletion Bugsnag/KSCrash/Source/KSCrash/Recording/BSG_KSSystemInfo.m
View file
Original file line number Diff line number Diff line change
@@ -418,7 +418,7 @@ + (NSDictionary *)buildSystemInfoStatic {
sysInfo[@BSG_KSSystemField_BinaryArch] = [self CPUArchForCPUType:header->cputype subType:header->cpusubtype];
sysInfo[@BSG_KSSystemField_DeviceAppHash] = [self deviceAndAppHash];

#if TARGET_OS_OSX || TARGET_OS_MACCATALYST || TARGET_OS_SIMULATOR
#if TARGET_OS_OSX || (defined(TARGET_OS_MACCATALYST) && TARGET_OS_MACCATALYST) || TARGET_OS_SIMULATOR
// https://developer.apple.com/documentation/apple-silicon/about-the-rosetta-translation-environment
int proc_translated = 0;
size_t size = sizeof(proc_translated);
2 changes: 1 addition & 1 deletion Bugsnag/KSCrash/Source/KSCrash/Recording/Sentry/BSG_KSCrashSentry_NSException.m
View file
Original file line number Diff line number Diff line change
@@ -182,7 +182,7 @@ static void bsg_reportException(id self, SEL _cmd, NSException *exception) {
bsg_kscrashsentry_endHandlingCrash();
}

#if TARGET_OS_MACCATALYST
#if defined(TARGET_OS_MACCATALYST) && TARGET_OS_MACCATALYST
// Mac Catalyst apps continue to run after an uncaught exception is thrown
// while handling a UI event. Our crash sentries should remain installed to
// catch any subsequent unhandled exceptions or crashes.