Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable -Wundef and fix warnings #1438

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Enable -Wundef and fix warnings #1438

merged 2 commits into from
Jul 18, 2022

Conversation

nickdowell
Copy link
Contributor

@nickdowell nickdowell commented Jul 18, 2022 •
edited
Loading

Goal

Catch potential programming errors due to mis-spelled macros named in #if statements.

Changeset

Adds -Wundef to WARNING_CFLAGS.

-Wundef

	Warn if an undefined identifier is evaluated in an #if directive.
	Such identifiers are replaced with zero.

Fixes resulting compiler warnings, including one mis-spelled TARGET_OS_* macro.

Testing

N/A

@nickdowell nickdowell requested review from kstenerud and kattrali July 18, 2022 07:56
@github-actions
Copy link

Bugsnag.framework binary size did not change - 804,968 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@nickdowell nickdowell merged commit 88859f4 into next Jul 18, 2022
@nickdowell nickdowell deleted the nickdowell/wundef branch July 18, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstenerud kstenerud kstenerud approved these changes

@kattrali kattrali Awaiting requested review from kattrali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickdowell @kstenerud