fix(ndk): link directly to liblog without find_library #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding it in the aar files built on Linux
lemnik
force-pushed
the
PLAT-6437/fix-liblog-included
branch
from
67aabfe to
06c1e9f
Compare
kattrali
approved these changes
May 24, 2021
fractalwrench
approved these changes
May 25, 2021
There was a problem hiding this comment.
LGTM. To resolve the ticket (and get publishing our artefacts via CI) it'd be good to check everything works end-to-end by pushing an artefact to Sonatype, testing it out via the staging repository, and then dropping the artefact so it's not published. I can assist with this if that'd be helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Stop including the
liblog.sofile in theaarfiles during a build on Linux.Testing
Affects the build process and has been checked on MacOS and Linux