Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Responses in ES #332

Closed
joekiller opened this issue Jul 6, 2016 · 7 comments
Closed

Store Responses in ES #332

joekiller opened this issue Jul 6, 2016 · 7 comments

Comments

@joekiller
Copy link
Contributor

We'd like to store responses in ES as well. A schema and basic architecture is needed.

@joekiller
Copy link
Contributor Author

Per #331 (comment) I think it may be easiest to just insert the response body into the ESRequestResponse struct

We could also try to support some of the most common response headers if we wanted: https://en.wikipedia.org/wiki/List_of_HTTP_header_fields#Response_fields

@joekiller
Copy link
Contributor Author

We could just use the (binary field type)[https://www.elastic.co/guide/en/elasticsearch/reference/current/binary.html] and dump the response and figure out other stuff later

@buger
Copy link
Owner

buger commented Jul 7, 2016

The problem with responses that they are arriving asynchronously from requests, so we have two options: inside ES plugin for each request wait for the response, and only after it received: send to ES. Alternative is to send responses separately.

UPDATE

Ah, my bad, I did not clarify issue. Here I was talking about original responses.

For replayed responses is it easy, and it is how it works now.

@joekiller
Copy link
Contributor Author

Okay that makes more sense. I didn't realize that the original response was being monitored or recorded. I'll take a look but if you have a quick link to it that'll help.

@buger
Copy link
Owner

buger commented Jul 7, 2016

@joekiller
Copy link
Contributor Author

Thanks!
On Jul 7, 2016 8:17 AM, "Leonid Bugaev" [email protected] wrote:

https://github.com/buger/gor/wiki/Capturing-and-replaying-traffic#tracking-responses


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#332 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AA-bx2sdGhulE8x4LkoR0pwHAyyS4U1Yks5qTO5bgaJpZM4JGTy5
.

@buger
Copy link
Owner

buger commented Aug 1, 2016

Will close it for now

@buger buger closed this as completed Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants