-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to latest elasticgo #331
Comments
Frankly, I thought about Elasticsearch as Pro option, because managing and testing third parties takes a lot of time and effort. Previous ES integration was written by one of the contributors, and it broke a long time ago without support. Currently, I even do not include it into the docs. What do you think about such approach? PS. |
I don't mind updating it to the latest. Git submodules is okay but godeps imo is better to solve the problem as each end up with trees in your project. It seems more natural for making go work. Being that it was a community contribution and the community has slowly updated it, I'd leave it in. Perhaps note that it is a community supported module so YMMV etc. |
If you are willing to make ES integration work, I'm ok to leave it as basic feature (make sense since it was added before announcing Pro). Regarding |
Okay. I'll check out vendoring in Go and try to get that working. PS I successfully got the elasticsearch output working with the latest elastigo here: https://github.com/o19s/gor/tree/elastigo I branched off #326 as it is related to my immediate work. I'll make it totally separate.
and then with |
Cool, thanks! |
I'm not an ES expert, what is the best way to store responses in ES as well? Can you suggest schema and basic architecture? |
Yeah I'll make that another issue. |
New version v0.15.0 include those fixes. Thanks! |
As noted in other tickets, the Elasticsearch output is broken. The project should be updated to use the latest elasticgo and godep to manage the dependencies.
The text was updated successfully, but these errors were encountered: