Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest elasticgo #331

Closed
joekiller opened this issue Jul 6, 2016 · 8 comments · Fixed by #333
Closed

update to latest elasticgo #331

joekiller opened this issue Jul 6, 2016 · 8 comments · Fixed by #333

Comments

@joekiller
Copy link
Contributor

As noted in other tickets, the Elasticsearch output is broken. The project should be updated to use the latest elasticgo and godep to manage the dependencies.

@buger
Copy link
Owner

buger commented Jul 6, 2016

Frankly, I thought about Elasticsearch as Pro option, because managing and testing third parties takes a lot of time and effort. Previous ES integration was written by one of the contributors, and it broke a long time ago without support. Currently, I even do not include it into the docs.

What do you think about such approach?

PS.
Regarding dependencies I'll probably prefer vendoring (maybe with git submodules).

@joekiller
Copy link
Contributor Author

I don't mind updating it to the latest. Git submodules is okay but godeps imo is better to solve the problem as each end up with trees in your project. It seems more natural for making go work.

Being that it was a community contribution and the community has slowly updated it, I'd leave it in. Perhaps note that it is a community supported module so YMMV etc.

@buger
Copy link
Owner

buger commented Jul 6, 2016

If you are willing to make ES integration work, I'm ok to leave it as basic feature (make sense since it was added before announcing Pro).

Regarding godep I just want to avoid any external tools, and vendoring Go experiment was success and now this feature supported by default.

@joekiller
Copy link
Contributor Author

Okay. I'll check out vendoring in Go and try to get that working.

PS I successfully got the elasticsearch output working with the latest elastigo here: https://github.com/o19s/gor/tree/elastigo

I branched off #326 as it is related to my immediate work. I'll make it totally separate.

docker run --name elasticsearch -p 9200:9200 -p 9300:9300 -d elasticsearch -Des.network.bind_host=0.0.0.0 -Dhttp.cors.enabled=true -Dhttp.cors.allow-origin="*"
docker run --name kibana --link elasticsearch:elasticsearch -p 5601:5601 -d kibana

and then with -output-http-elasticsearch localhost:9200/gor I can see:

image

@buger
Copy link
Owner

buger commented Jul 6, 2016

Cool, thanks!

@buger
Copy link
Owner

buger commented Jul 6, 2016

I'm not an ES expert, what is the best way to store responses in ES as well? Can you suggest schema and basic architecture?

@joekiller
Copy link
Contributor Author

Yeah I'll make that another issue.

@buger buger closed this as completed in #333 Jul 7, 2016
buger pushed a commit that referenced this issue Jul 7, 2016
)

* add elastigo submodule

* add gou submodule

* add go-hostpool submodule

* use vendored elasticgo

* update ReqUrl to ReqURL
@buger
Copy link
Owner

buger commented Aug 11, 2016

New version v0.15.0 include those fixes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants