Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve "Rename KrakenBaseSpotAPI to KrakenSpotBaseAPI and KrakenBaseFuturesAPI to KrakenFuturesBaseAPI" #159

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Resolve "Rename KrakenBaseSpotAPI to KrakenSpotBaseAPI and KrakenBaseFuturesAPI to KrakenFuturesBaseAPI" #159

merged 1 commit into from
Sep 4, 2023

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Sep 4, 2023 •
edited
Loading

Summary

The base clients were renamed.

@btschwertfeger btschwertfeger added this to the v2.0.0 milestone Sep 4, 2023
@btschwertfeger btschwertfeger self-assigned this Sep 4, 2023
@btschwertfeger btschwertfeger linked an issue Sep 4, 2023 that may be closed by this pull request
Rename KrakenBaseSpotAPI to KrakenSpotBaseAPI and KrakenBaseFuturesAPI to KrakenFuturesBaseAPI #158
Closed
@btschwertfeger btschwertfeger changed the title rename Base API classes Resolve "Rename KrakenBaseSpotAPI to KrakenSpotBaseAPI and KrakenBaseFuturesAPI to KrakenFuturesBaseAPI" Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #159 (901cc73) into v2 (3c4a4c3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2     #159   +/-   ##
=======================================
  Coverage   90.11%   90.11%           
=======================================
  Files          20       20           
  Lines        1750     1750           
=======================================
  Hits         1577     1577           
  Misses        173      173
Flag Coverage Δ
unittests 90.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
kraken/base_api/__init__.py 100.00%
kraken/futures/funding.py 100.00%
kraken/futures/market.py 100.00%
kraken/futures/trade.py 100.00%
kraken/futures/user.py 100.00%
kraken/futures/ws_client.py 100.00%
kraken/spot/funding.py 100.00%
kraken/spot/market.py 100.00%
kraken/spot/staking.py 100.00%
kraken/spot/trade.py 100.00%
... and 2 more

@btschwertfeger btschwertfeger marked this pull request as ready for review September 4, 2023 14:07
@btschwertfeger btschwertfeger merged commit e2ab268 into v2 Sep 4, 2023
18 checks passed
@btschwertfeger btschwertfeger deleted the 158-rename-krakenbasespotapi-to-krakenspotbaseapi branch September 4, 2023 14:08
@btschwertfeger btschwertfeger added Futures Topic related to Futures trading Spot Topic related to Spot trading Breaking Breaking changes labels Oct 22, 2023
btschwertfeger added a commit that referenced this pull request Mar 12, 2024
@btschwertfeger
Resolve "Rename KrakenBaseSpotAPI to KrakenSpotBaseAPI and `Krake…
5ed40f4 
…nBaseFuturesAPI` to `KrakenFuturesBaseAPI`" (#159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@btschwertfeger btschwertfeger

Labels
Breaking Breaking changes Futures Topic related to Futures trading Spot Topic related to Spot trading
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Rename KrakenBaseSpotAPI to KrakenSpotBaseAPI and KrakenBaseFuturesAPI to KrakenFuturesBaseAPI
1 participant
@btschwertfeger