Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename KrakenBaseSpotAPI to KrakenSpotBaseAPI and KrakenBaseFuturesAPI to KrakenFuturesBaseAPI #158

Closed
btschwertfeger opened this issue Sep 3, 2023 · 0 comments · Fixed by #159
Closed

Rename KrakenBaseSpotAPI to KrakenSpotBaseAPI and KrakenBaseFuturesAPI to KrakenFuturesBaseAPI #158

btschwertfeger opened this issue Sep 3, 2023 · 0 comments · Fixed by #159
Assignees
@btschwertfeger
Labels
Breaking Breaking changes Futures Topic related to Futures trading Spot Topic related to Spot trading
Milestone
v2.0.0

Comments

@btschwertfeger
Copy link
Owner

The naming could be better. Its more a could but should be done for v2.
@btschwertfeger btschwertfeger added this to the v2.0.0 milestone Sep 3, 2023
@btschwertfeger btschwertfeger self-assigned this Sep 3, 2023
@btschwertfeger btschwertfeger changed the title Rename KrakenBaseSpotAPI to KrakenSpotBaseAPI Rename KrakenBaseSpotAPI to KrakenSpotBaseAPI and KrakenBaseFuturesAPI to KrakenFuturesBaseAPI Sep 4, 2023
This was linked to pull requests Sep 4, 2023
Resolve "Rename KrakenBaseSpotAPI to KrakenSpotBaseAPI and KrakenBaseFuturesAPI to KrakenFuturesBaseAPI" #159
Merged
Resolve "Rename kraken.spot.KrakenSpotWSClient to kraken.spot.KrakenSpotWSClientV1" #160
Merged
@btschwertfeger btschwertfeger added the Breaking Breaking changes label Sep 4, 2023
@btschwertfeger btschwertfeger removed a link to a pull request Sep 4, 2023
Resolve "Rename kraken.spot.KrakenSpotWSClient to kraken.spot.KrakenSpotWSClientV1" #160
Merged
@btschwertfeger btschwertfeger added Futures Topic related to Futures trading Spot Topic related to Spot trading labels Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btschwertfeger btschwertfeger

Labels
Breaking Breaking changes Futures Topic related to Futures trading Spot Topic related to Spot trading
Projects
None yet
Milestone
v2.0.0
1 participant
@btschwertfeger