Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kraken.spot.Market.get_recent_trades parameter 'since' #120

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix kraken.spot.Market.get_recent_trades parameter 'since' #120

merged 1 commit into from
Jun 28, 2023

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Jun 28, 2023 •
edited
Loading

Summary

  • This PR fixes the kraken.spot.Market.get_recent_trades 'since' parameter which was always set to None. 
    if defined(since):
-  params["since"] = None
+  params["since"] = since
  • The count parameter was added to the mentioned function.

@btschwertfeger btschwertfeger added Bug Something isn't working Must This is a must Spot Topic related to Spot trading labels Jun 28, 2023
@btschwertfeger btschwertfeger self-assigned this Jun 28, 2023
@btschwertfeger btschwertfeger linked an issue Jun 28, 2023 that may be closed by this pull request
kraken.spot.Market.get_recent_trades: 'since' parameter does not work #119
Closed
@btschwertfeger btschwertfeger added this to the v1.4.1 milestone Jun 28, 2023
@btschwertfeger btschwertfeger marked this pull request as ready for review June 28, 2023 16:38
@btschwertfeger btschwertfeger merged commit 4563042 into master Jun 28, 2023
@btschwertfeger btschwertfeger deleted the 119-marketget_recent_trades-since-parameter-does-not-work branch June 28, 2023 16:38
btschwertfeger added a commit that referenced this pull request Mar 12, 2024
@btschwertfeger
Fix kraken.spot.Market.get_recent_trades parameter 'since' (#120)
db24300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@btschwertfeger btschwertfeger

Labels
Bug Something isn't working Must This is a must Spot Topic related to Spot trading
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.

kraken.spot.Market.get_recent_trades: 'since' parameter does not work
1 participant
@btschwertfeger