kraken.spot.Market.get_recent_trades: 'since' parameter does not work

[andyDoucette]

I'm using version 1.4.0

https://docs.kraken.com/rest/#tag/Market-Data/operation/getRecentTrades says that the since parameter "Filter trades since given timestamp".

Supplying the since parameter has no effect.

I can see in the code that:

362             params: dict = {"pair": pair}
363             if defined(since):
364                 params["since"] = None

I wonder if line 364 should be params["since"] = since instead, or something like that? Seems like it's being set to None no matter what, which is probably why the feature isn't working.

[btschwertfeger]

kraken.spot.User.get_trades_history do not use the the since parameter (kraken/spot/user.py#L468-L538). This is also not part of the documentation you linked.

start is what you are looking for.

[andyDoucette]

Hey sorry. I sent the wrong docs link. The title and rest of the description was intended.

[btschwertfeger]

I see - and will fix that. Thank you!

[andyDoucette]

Your'e welcome. :) I hope you have a great day, Ben.

…

On Wed, Jun 28, 2023 at 3:05 PM Benjamin T. Schwertfeger < ***@***.***> wrote: I see - and will fix that. Thank you! — Reply to this email directly, view it on GitHub <#119 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEVLQ5SRMTPSET6WMLZM4YDXNPQTPANCNFSM6AAAAAAZWLQLWY> . You are receiving this because you authored the thread.Message ID: ***@***.***>