Fix container stop and destroy procedure #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grembo
force-pushed
the
fix-stop-destroy
branch
from
7bf4702 to
0325c57
Compare
|
There's more to it, I will fix and expand this. |
These commands erroneously appended taskCfg.Args to both commands, resulting in various undesirable outcomes, depending on the value if taskCfg.Args. One obvious problem is, that the appended "-F" to pot-destroy never came into effect. Args starting with "-" could also make the commands do different things or fail completely. While investigating, I found that there are more things wrong with this (partially due to how pot handles things). As a result, this change removes using the stop command and instead relies on calling destroy -F. Destroying the container is done exactly one (enforced using an atomic counter), so double-destroy, which happened in the past and messed up things, should not happen anymore. While there, bump plugin version.
grembo
force-pushed
the
fix-stop-destroy
branch
from
0325c57 to
0aa3f98
Compare
grembo
changed the title
|
@pizzamig @ebarriosjr Now this should be much cleaner. I haven't tested this in our staging environment yet, but I think there is a non-zero chance this will actually fix bsdpot/pot#272 |
|
@ebarriosjr Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commands erroneously appended taskCfg.Args to both commands,
resulting in various undesirable outcomes, depending on the value
if taskCfg.Args. One obvious problem is, that the appended "-F"
to pot-destroy never came into effect. Args starting with "-" could
also make the commands do different things or fail completely.
While investigating, I found that there are more things wrong with
this (partially due to how pot handles things).
As a result, this change removes using the stop command and
instead relies on calling destroy -F. Destroying the container
is done exactly one (enforced using an atomic counter), so
double-destroy, which happened in the past and messed up
things, should not happen anymore.
While there, bump plugin version.