Skip to content

Commit

Permalink
Fix stop and destroy commands
Browse files Browse the repository at this point in the history
These commands erroneously appended taskCfg.Args to both commands,
resulting in various undesirable outcomes, depending on the value
if taskCfg.Args. One obvious problem is, that the appended "-F"
to pot-destroy never came into effect. Args starting with "-" could
also make the commands do different things or fail completely.
  • Loading branch information
grembo committed Dec 21, 2023
1 parent 1fa712f commit 0325c57
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- Fix pot-stop and pot-destroy command invocations (#49)

## [0.9.1] - 2023-09-29
### Added
- Add optional keyword "attributes" to set pot attributes like `devfs_ruleset` on the task (#42)
Expand Down
4 changes: 0 additions & 4 deletions driver/prepare.go
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,6 @@ func prepareStop(cfg *drivers.TaskConfig, taskCfg TaskConfig) syexec {

argv = append(argv, completeName)

se.argvStop = append(argv, taskCfg.Args...)

return se
}

Expand All @@ -266,8 +264,6 @@ func prepareDestroy(cfg *drivers.TaskConfig, taskCfg TaskConfig) syexec {

argv = append(argv, "-p", completeName)

se.argvDestroy = append(argv, taskCfg.Args...)

return se

}
Expand Down

0 comments on commit 0325c57

Please sign in to comment.