Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: stream command for T8420 #171

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Fix: stream command for T8420 #171

merged 1 commit into from
Jul 16, 2022

Conversation

thieren
Copy link
Contributor

@thieren thieren commented Jun 17, 2022

Starting a local livestream on Floodlight (T8420) fails due to wrong command used.

See here for reference.

This fixes this (tested), but could be the wrong approach.

I added the specific check for the serial since I don't know if all DeviceType.FLOODLIGHT are T8420 devices. If so a simple change from !== to === would suffice of course.

@bropat bropat merged commit 0d424fe into bropat:develop Jul 16, 2022
bropat added a commit that referenced this pull request Jul 16, 2022
@bropat
Merged #180 - Add alarm arm delay event
bf968de 
Merged #171 - Fix: stream command for T8420
Merged #169 - Don't send the alarm armed p2p events as alarm events
Fixed issue #167
Fixed issue #161
Updated versions of the package dependencies
@thieren thieren mentioned this pull request Sep 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thieren @bropat