-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Since V2 the EUFY Floodlight Cam 2 2K WiFi Outdoor Security Camera causes Homebridge to crash #72
Comments
Did you check this Common Issues pages ? |
Hey @gdotp01 could you try the latest beta please? Does this resolve your issue? Furthermore if not: please provide your json config and a debug log output with a few messages before the error. |
Im experiencing the same issue. Running on the latest beta.
With RTSP disabled for the floodlight
|
Hey @jangeja94 Thx for participating and for your feedback. Can you enable debug log output? It's in the advanced settings in the config UI. |
Hey @thieren I enabled it. I'm also still seeing this log when the eufy-security plugin restarts, which is odd because the camera is already added in homekit.
Here are the debug logs with rtsp disabled.
|
Hmm Shouldnt the camera config use the rtspStream property rather than these lines be using the Havent read too much into the source code so I probably dont know what im talking about :) |
Yeah. I too am not entirely satisfied with the way the rtsp setting is working right now. But internally it makes sense: you'll have to look at the whole method All these have to be fulfilled so that rtsp can work. But as you were right noticing the way it is done now the user thinks rtsp will be used when he just sets it to enabled in the plugin config. I think that will be handled differently in the future. As for your case: the rtsp setting does nothing for you, since the plugin determines that the device doesn't have the capabilities. You can see that this property is not included here (I believe the T8424 model is correct here) If that is true, or if it is an error I can't say since I don't own that device. However since this can't be used the plugin tries to fallback to the standard local livestream, which unfortunately also fails. Why this is remains to be investigated. I'll come back to you on this one. |
So after investigating a little further, here's what I found:
I'll implement it so that the rtmp/cloud stream will be used as fallback, if rtsp is not supported by the device. As for the fail on p2p local live-streaming:If it's possible for you I'd recommend you try a tool of mine here with this you are able to manually start/stop a p2p stream and also a cloud stream. You can see in the logs if this succeeded. If you have any questions regarding this I'd recommend you write to me on discord or open an issue at the page of the tool (since this is out-of-scope of this plugin). |
Tried that tool and selected walkway Light and its just hanging
|
Yeah. Not much documentation. Just hit enter and it will go back to the devices menu. |
Did some research today and tried implementing the cloud streaming as fallback option. Unfortunately this stream option seems to be really unreliable. I got at best a 50 percent chance to start the stream. Guess there was a reason to ditch this method from the plugin in the first place. I'd like to concentrate on why the p2p local stream is not working for you. So if you could try again with the tool, this would help (added some short instructions on the readme page). |
Heres the relevant logs for the camera when I tried to initiate p2p. I see multiple station connects/disconnects for the other 2 cameras that I have in my account without me even initiating the p2p connections via the cli, so im not sure how those are getting in there. I filtered these out by grepping for the serial of the camera in question (flood light) I also redacted some info. Plopped the hex codes in an asci converter with no luck on those hex messages. Not really sure what this all means. Also looks like the p2p was successful ? Judging from the success code returned.
|
Just started a P2p on a camera that works with homekit natievly, and with homebridge via this plugin, and I see a different log line. I also dont see the disconnect log line that we did with the floodlight
Versuse this log line from the floodlight:
|
Hey @jangeja94 Thx for the logs. Your help is much appreciated.
So (if you didn't already know) the underlying connection is established through the eufy-security-client library. This will connect to the eufy cloud at startup and refresh every device. Part of this process is to get the device status/information through a local connection (p2p). That should be fairly standard. And I believe that is what your seeing here. Also this proves that the whole issue is with the eufy-security-client library as opposed to our plugin.
That's pretty normal as different eufy devices and software revisions do need different payloads. Why this is exactly I don't know, but if you look at the source code there are a lot of distinction between the devices to get the right commands. Actually I've even found a comment that hints in the right direction. I have added some code to test. Just replace Alternatively you could install the whole tool again, since I've updated the dependency with a test branch. |
Oh nice find ! I was digging through the eufy-security-client yesterday and must have missed that. Ill try this fix. |
Unfortunately That didnt resolve the issue. I still see the disconnect line for the floodlight with the latest eufy-test-client. So now the floodlight is sending that command, but it doesn't appear to be working still.
|
Are you sure you've run |
😞 I should have known the
|
We rely on the master version of the eufy-security-client repo. So I'll open a PR and let @bropat check. |
This should be fixed with latest beta. |
I installed the latest beta and now I see this error. It continues to exit and restart.
|
Seems like pnpm is handling the dependencies in another way completely. I will introduce a workaround in the next version but out of curiosity: what installation method for homebridge did you use? |
Running homebridge in docker. I was able to fix it by symlinking the node_modules dir. Unfortunately, I am still getting the orginal issue where its crashing the bridge.
Possible relevant config:
|
Can you send me your |
Is fixed with release of 2.1.0 |
What happened?
Since V2 the EUFY Floodlight Cam 2 2K WiFi Outdoor Security Camera causes Homebridge to crash when its enabled.
Device Type
Floodlight (Supported)
Plugin Version
v2.0.x (Supported)
HomeBridge Version
v1.4.x (Supported)
NodeJS Version
v14 (Supported)
Operating System
Raspbian 10+ (Supported)
Relevant log output
The text was updated successfully, but these errors were encountered: