Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lofreq task portability, misc other edits #426

Merged
merged 8 commits into from
Jun 9, 2022
Merged

lofreq task portability, misc other edits #426

merged 8 commits into from
Jun 9, 2022

Conversation

dpark01
Copy link
Member

@dpark01 dpark01 commented Jun 8, 2022

This PR introduces 3 small unrelated improvements:

  1. task lofreq was written in a way that presumed writability of new files in the localization directory. This fails in execution environments that mount input files into the container as read only. Change WDL task behavior to make local copies before indexing.
  2. Rename WDL task ncbi.package_genbank_ftp_submission to ncbi.package_sc2_genbank_ftp_submission, since the format of the zip package produced is not universally accepted for all species at Genbank yet.
  3. assemble_denovo: percolate sample_name to scaffolding input so that output fasta files are named properly.

@dpark01 dpark01 changed the title improve lofreq task portability lofreq task portability, misc other edits Jun 9, 2022
@dpark01 dpark01 merged commit 2bfde65 into master Jun 9, 2022
@dpark01 dpark01 deleted the dp-cdc branch June 9, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant