Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from spin to conquer-once #1053

Conversation

ErichDonGubler
Copy link

This resolves RUSTSEC-2019-0031.


The advisory page suggests several alternatives to the now-deprecated spin crate. The reason I picked conquer-once was because it seemed to have the most similar (and limited) API to how spin was being used -- it seemed a good small dependency to trade for.

@ErichDonGubler
Copy link
Author

The CI failures here don't seem related, esp. since they're occurring in other PRs right now (for example, this one).

@kellpossible
Copy link

Seems like spin is being maintained again now with a new 0.6 release?

@ErichDonGubler
Copy link
Author

@kellpossible: I've asked in upstream spin for clarification around the current maintainership of the project.

@briansmith
Copy link
Owner

Thanks for the PR. I also saw your most recent comment in the issue. I do think we should just close this. I don't know if conquer-once or spin-rs is better but also I don't want to spend a lot of time on the issue. As was noted in the issue, cargo deny is no longer warning about spin-rs so this isn't urgent. Thanks again for the PR though!

@briansmith briansmith closed this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants