-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Making Smart Connections..." Runs Indefinitely #244
Comments
@fenrirlycan are you able to share those notes with me so I can debug this? Thanks for your help |
I am seeing the same thing. Every time a switch to a note note the "Making Smart Connections..." part opens and starts counting up indefinitely. I have well less than 1000 notes in vault. One example I can share is the following: ---
type: fleeting_note
tags: status/fleeting_note, status/unprocessed
dates: 2023-06-12 11:31
people:
relevant:
aliases: [HCl]
---
# # Hydrochloric Acid
|
@ajsteven130 That counting up doesn't indicate much on it's own. Check the developer console to see if any errors appear there and if possible screenshot them so I can check them out. Thanks |
Once I was able to create the embeddings using the button in the side panel, this stopped happening. Everything seems ok now... |
It only seemed to happen before I had made the embeddings |
Glad to hear it's working now. Thanks for following up! Brian 🌴 |
It still isn't working for me. I'm a new Obsidian user and I don't have any embeddings. My vault has 13 notes as of today, so definitely not millions of connections to be made, haha.
I haven't made any embeddings yet, so I guess I'll try that. How do I create the embeddings? |
Weird, I did nothing different and suddenly it works. I wish I could reproduce the bug so I can give you the debug logs. If it comes up again, I'll try to figure it out a make a PR! Thanks for your hard work, I appreciate it! |
@fenrirlycan The embeddings are necessary for the plugin to work. Not sure what you did, but hopefully whatever it was will be fixed soon as I'm cleaning up the codebase. Lots of bugs here and there are simply because this plugin wasn't planned and was more an experiment that continued to gain additional layers. Those layers added up to a lot of unnecessary complexity which I'm (slowly) getting organized into something more manageable. Thanks for following up |
I had this issue but after stopping and restarting the plugin from settings it now works wonderfull. Really powerful plug-in! Thank you :) |
Yes! This happened for all my vaults, just counting up infinitely... |
@tondeaf did you check to see if your API key is working in the settings? Was the plugin working for you prior to this? Thanks for your help |
API key works. Plugin didn't work at all yet. Just started counting Very High. Edit: ok, now it looks like something has happened. I guess it shouldn't be counting endlessly? What is the count about? So it vectorizes in the background? May not have access to the vectors yet? Ok. This problem is resolved...search works now. But now I will find a different thread for my next issue... |
@tondeaf the counting up doesn't mean much. Basically, it was just an indicator I created during the development process to recognize when a process was running. Thanks for following up |
First off, this is just such an incredible plugin! @brianpetro I also encountered the issue discussed in this thread. What fixed it eventually were these steps:
|
Thanks for clarifying this. That's a necessary step in the setup process that I need to better document or at least improve the UX. Thanks, |
You're welcome! |
@AW2307 yes, that is the intended behavior. It must have been accidentally changed in some past update. I will have to review that UX to fix it. Thanks for the clarification and bringing that to my attention |
Came here to report this bug: Its comforting reading that this is not a token count or related to the API - I thought this was racking up an initiation bill $$ Some guidance would be great here:
Should I create these manually? I'm afraid to interrupt the process as it's been more than an hour to get this far, with no buttons appearing. |
@MorganOnCode don't worry about interrupting that. This is a bug that I haven't been able to address yet. Possibly a restart will bring up a view in that same window that says "create embeddings file". Let me know if that helps. 🌴 |
@MorganOnCode, hopefully, you got this working. If not, updating to the latest Thanks for bringing this to my attention, |
Thank you so much @brianpetro - I just updated the plugin and it's resolved for me; the two buttons appeared, and I've initiated the embeddings file. |
@Sheemie did you hit the "create embeddings.json" button? 🌴 |
Thank you @brianpetro for the reply. My issue is I don’t know where are the buttons. I attached the screenshot which shows two buttons when the plug-in starts making smart connections. None of them relates to embedding. Did I miss something? By the way, I can’t wait to use your plug-in. I have no doubt that this is going to be fantastic. Thank you for making this. |
@Sheemie try turning on an off the plugin without any notes open. The buttons should appear in the same place as your screenshot. 🌴 |
@Sheemie it should look like this 🌴 |
Maybe I could delete the file to trigger it?
Update:
I close all the tabs, disabled the plug-in, deleted the embeddings.json and then re-enable it, it works properly
…On Thu, Jun 22, 2023 at 8:07 PM WFH Brian ***@***.***> wrote:
@Sheemie <https://github.com/Sheemie> it should look like this
[image: Screenshot 2023-06-22 at 8 06 27 PM]
<https://user-images.githubusercontent.com/1886014/248103493-7edff8df-c858-4730-afd8-4a5910b1823b.png>
—
Reply to this email directly, view it on GitHub
<#244 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2S2DS3NL74IRUIU3KCRIVLXMTM37ANCNFSM6AAAAAAZFYA7UA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I still can't get this working on my setup. I'm running Obsidian on Linux, maybe that's why. Bummer. Let me know if there is anything I can provide to help you fix this bug. It still just runs indefinitely, enabling and disabling doesn't work. I dont see the "create embeddings". Correction, got it working by uninstalling and reinstalling it (again, 5th times the charm I guess). Can't wait to use it! Thanks, @brianpetro ! |
@LycanDarko666 thanks for letting me know about this. It seems like quite a few people keep having this issue during the initial setup. I will have to continue to look into it further. Thanks, |
I installed the plugin today and set up the OpenAI API key, including setting up a payment method (and limits!). I can see there, I've spent 7 cents. So, something is working correctly. Or maybe not -- it's been saying Moving around in my vault has been incredibly sluggish since I first enabled the plugin. That suggests the embedding process may still be running? Is there's another indicator besides I'm on Win 10 Home, running Obsidian 1.4.2 and Smart Connections 1.6.34. LMK if there's other information I can provide. It appears you hear this frequently already, but this looks to be a powerful plugin and I'm eager to see it in action! Thanks for all the awesomeness, |
@annekaelber see this comment #289 (comment) If you haven't already, restarting Obsidian may also help. If you're still having issues after that, let me know. Thanks, |
It appears to be okay. The only failed file is the output for the Find orphans plugin, which I'm not concerned about. I haven't had a chance to 'test drive' and see if the sluggish-ness is also gone. Will report back one way or the other. Thank you for your replies! |
I have two small notes in my Obsidian vault and has been 10 hours and made millions of connections and keeps going. I am unable to use it.
Thought it was hijacking tokens for a second because of it. I was wrong, but unfortunate that I am unable to use it. Sounds like a great idea.
The text was updated successfully, but these errors were encountered: