Issue 88 : modify with timezone #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Issue 88 : Adding to a time provides an inconsistent result](briannesbitt#88)
|
A test case to proof the underlying issue and that this solves it would be useful. |
|
Need test cases. |
|
Done. |
|
This creates 39 failed tests ?? |
|
|
|
It seems $this->setTimezone($tz); do not restore correctly the timezone if empty. But there is no bug if we test first if the timezone is different from a default one. I will see if I can find a shorter solution. |
|
What is the status of this PR @kylekatarnls @briannesbitt ? |
|
No shorter fix found |
|
Can you rebase this PR maybe ? |
|
Do you guys consider this a BC or a bug fix ? |
Merged
|
Should be closed in favour of #548. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 88 : Adding to a time provides an inconsistent result