Fix issue 88 #548
Merged
Fix issue 88 #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
|
👍 |
|
Any ETA on this getting merged? this will resolve an issue we're experiencing. |
|
ping @briannesbitt |
Ovsyanka
added a commit
to Ovsyanka/Carbon
that referenced
this pull request
Jan 15, 2018
The realisation of initial issue briannesbitt#88 is wrong. The problem does not relies to `local` / `not local` timezone. Php handles date changes similar for both cases. So in fact changes was made 'fixes' non-local dates but local dates works same as before. And it 'fixes' the problem and not actually fixes it because in fact the PHP handling of DST changing in non-UTC dates is quite right. If developer don't want to adjusting timestamp to DST change he should use UTC timezone. Next commits reverted by hand because conflicts in automatic revert. * Commit 2cc6988 Fix CS 07.12.2015 13:04 Lucas Michot * Commit 5394301 Fix issue 88 07.12.2015 12:55 Lucas Michot
Ovsyanka
added a commit
to Ovsyanka/Carbon
that referenced
this pull request
Jan 15, 2018
The realisation of initial issue briannesbitt#88 is wrong. The problem does not relies to `local` / `not local` timezone. Php handles date changes similar for both cases. So in fact changes was made 'fixes' non-local dates but local dates works same as before. And it 'fixes' the problem and not actually fixes it because in fact the PHP handling of DST changing in non-UTC dates is quite right. If developer don't want to adjusting timestamp to DST change he should use UTC timezone. Next commits reverted by hand because conflicts in automatic revert. * Commit 2cc6988 Fix CS 07.12.2015 13:04 Lucas Michot * Commit 5394301 Fix issue 88 07.12.2015 12:55 Lucas Michot
Ovsyanka
added a commit
to Ovsyanka/Carbon
that referenced
this pull request
Jan 15, 2018
The realisation of initial issue briannesbitt#88 is wrong. The problem does not relies to `local` / `not local` timezone. Php handles date changes similar for both cases. So in fact changes was made 'fixes' non-local dates but local dates works same as before. And it 'fixes' the problem and not actually fixes it because in fact the PHP handling of DST changing in non-UTC dates is quite right. If developer don't want to adjusting timestamp to DST change he should use UTC timezone. Next commits reverted by hand because conflicts in automatic revert. * Commit 2cc6988 Fix CS 07.12.2015 13:04 Lucas Michot * Commit 5394301 Fix issue 88 07.12.2015 12:55 Lucas Michot
Ovsyanka
added a commit
to Ovsyanka/Carbon
that referenced
this pull request
Jan 15, 2018
…about issue briannesbitt#88 The realisation of initial issue briannesbitt#88 is wrong. The problem does not relies to `local` / `not local` timezone. Php handles date changes similar for both cases. So in fact changes was made 'fixes' non-local dates but local dates works same as before. And it 'fixes' the problem and not actually fixes it because in fact the PHP handling of DST changing in non-UTC dates is quite right. If developer don't want to adjusting timestamp to DST change he should use UTC timezone. Next commits reverted by hand because conflicts in automatic revert. * Commit 2cc6988 Fix CS 07.12.2015 13:04 Lucas Michot * Commit 5394301 Fix issue 88 07.12.2015 12:55 Lucas Michot
Ovsyanka
added a commit
to Ovsyanka/Carbon
that referenced
this pull request
Feb 13, 2018
…about issue briannesbitt#88 The realisation of initial issue briannesbitt#88 is wrong. The problem does not relies to `local` / `not local` timezone. Php handles date changes similar for both cases. So in fact changes was made 'fixes' non-local dates but local dates works same as before. And it 'fixes' the problem and not actually fixes it because in fact the PHP handling of DST changing in non-UTC dates is quite right. If developer don't want to adjusting timestamp to DST change he should use UTC timezone. Next commits reverted by hand because conflicts in automatic revert. * Commit 2cc6988 Fix CS 07.12.2015 13:04 Lucas Michot * Commit 5394301 Fix issue 88 07.12.2015 12:55 Lucas Michot
Ovsyanka
added a commit
to Ovsyanka/Carbon
that referenced
this pull request
Feb 13, 2018
…about issue briannesbitt#88 The realisation of initial issue briannesbitt#88 is wrong. The problem does not relies to `local` / `not local` timezone. Php handles date changes similar for both cases. So in fact changes was made 'fixes' non-local dates but local dates works same as before. And it 'fixes' the problem and not actually fixes it because in fact the PHP handling of DST changing in non-UTC dates is quite right. If developer don't want to adjusting timestamp to DST change he should use UTC timezone. The unit tests added to assure default php behavior. Next commits reverted by hand because conflicts in automatic revert. * Commit 2cc6988 Fix CS 07.12.2015 13:04 Lucas Michot * Commit 5394301 Fix issue 88 07.12.2015 12:55 Lucas Michot
Ovsyanka
added a commit
to Ovsyanka/Carbon
that referenced
this pull request
Feb 13, 2018
…about issue briannesbitt#88 The realisation of initial issue briannesbitt#88 is wrong. The problem does not relies to `local` / `not local` timezone. Php handles date changes similar for both cases. So in fact changes was made 'fixes' non-local dates but local dates works same as before. And it 'fixes' the problem and not actually fixes it because in fact the PHP handling of DST changing in non-UTC dates is quite right. If developer don't want to adjusting timestamp to DST change he should use UTC timezone. The unit tests added to assure default php behavior. Next commits reverted by hand because conflicts in automatic revert. * Commit 2cc6988 Fix CS 07.12.2015 13:04 Lucas Michot * Commit 5394301 Fix issue 88 07.12.2015 12:55 Lucas Michot
Ovsyanka
added a commit
to Ovsyanka/Carbon
that referenced
this pull request
Feb 26, 2018
…about issue briannesbitt#88 The realisation of initial issue briannesbitt#88 is wrong. The problem does not relies to `local` / `not local` timezone. Php handles date changes similar for both cases. So in fact changes was made 'fixes' non-local dates but local dates works same as before. And it 'fixes' the problem and not actually fixes it because in fact the PHP handling of DST changing in non-UTC dates is quite right. If developer don't want to adjusting timestamp to DST change he should use UTC timezone. Next commits reverted by hand because conflicts in automatic revert. * Commit 2cc6988 Fix CS 07.12.2015 13:04 Lucas Michot * Commit 5394301 Fix issue 88 07.12.2015 12:55 Lucas Michot
Ovsyanka
added a commit
to Ovsyanka/Carbon
that referenced
this pull request
Feb 26, 2018
…about issue briannesbitt#88 The realisation of initial issue briannesbitt#88 is wrong. The problem does not relies to `local` / `not local` timezone. Php handles date changes similar for both cases. So in fact changes was made 'fixes' non-local dates but local dates works same as before. And it 'fixes' the problem and not actually fixes it because in fact the PHP handling of DST changing in non-UTC dates is quite right. If developer don't want to adjusting timestamp to DST change he should use UTC timezone. The unit tests added to assure default php behavior. Next commits reverted by hand because conflicts in automatic revert. * Commit 2cc6988 Fix CS 07.12.2015 13:04 Lucas Michot * Commit 5394301 Fix issue 88 07.12.2015 12:55 Lucas Michot
Ovsyanka
added a commit
to Ovsyanka/Carbon
that referenced
this pull request
Feb 26, 2018
…about issue briannesbitt#88 The realisation of initial issue briannesbitt#88 is wrong. The problem does not relies to `local` / `not local` timezone. Php handles date changes similar for both cases. So in fact changes was made 'fixes' non-local dates but local dates works same as before. And it 'fixes' the problem and not actually fixes it because in fact the PHP handling of DST changing in non-UTC dates is quite right. If developer don't want to adjusting timestamp to DST change he should use UTC timezone. The unit tests added to assure default php behavior. Next commits reverted by hand because conflicts in automatic revert. * Commit 2cc6988 Fix CS 07.12.2015 13:04 Lucas Michot * Commit 5394301 Fix issue 88 07.12.2015 12:55 Lucas Michot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #90 and fix #88