Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Priority balance doesn't work with portrait images #115

Merged
merged 1 commit into from
Jun 16, 2019
Merged

Priority balance doesn't work with portrait images #115

merged 1 commit into from
Jun 16, 2019

Conversation

phuchuynhStrong
Copy link
Contributor

@phuchuynhStrong phuchuynhStrong commented Jun 15, 2019 •
edited
Loading

Priority balance not work with portrait images:

  • In the _insertIntoColumn function, use scaled height instead of brick's image original height
  • In balance priority, the call to resolveBricks function in componentDidMount will be moved to setState function after setParentDimensions. Scaled height need column width to calculate so this change will make sure resolveBricks always get dimensions

@phuchuynhStrong
[FIXED]
deb55ee 
- Priority balance not work with portrait images
@phuchuynhStrong phuchuynhStrong changed the title [FIXED] Priority balance not work with portrait images Jun 15, 2019
@phuchuynhStrong phuchuynhStrong changed the title Priority balance not work with portrait images Priority balance doesn't work with portrait images Jun 15, 2019
@phuchuynhStrong phuchuynhStrong mentioned this pull request Jun 15, 2019
Closed
@brh55 brh55 merged commit 7786657 into brh55:master Jun 16, 2019
@brh55
Copy link
Owner

brh55 commented Jun 16, 2019 •
edited
Loading

Excellent, dig it! Appreciate the PR :)

@phuchuynhStrong
Copy link
Contributor Author

Thank in advance. I really enjoy your library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phuchuynhStrong @brh55