You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the _insertIntoColumn function, use scaled height instead of brick's image original height
In balance priority, the call to resolveBricks function in componentDidMount will be moved to setState function after setParentDimensions. Scaled height need column width to calculate so this change will make sure resolveBricks always get dimensions
Steps to Reproduce
Add a Masonry into your View
Use FastImage as your customImageComponent, priority balance
Add some bricks with square and portrait images
Context (Environment)
react-native version 0.56.0 react-native-masonry version 0.5.0-alpha.4
Expected Behavior
Current Behavior
Possible Solution
_insertIntoColumn
function, use scaled height instead of brick's image original heightresolveBricks
function in componentDidMount will be moved tosetState
function aftersetParentDimensions
. Scaled height need column width to calculate so this change will make sureresolveBricks
always getdimensions
Steps to Reproduce
customImageComponent
, prioritybalance
Context (Environment)
react-native
version0.56.0
react-native-masonry
version0.5.0-alpha.4
Detailed Description
The code which I'm using
Possible Implementation
I have open a pull-request for the fix. The link is #115
The text was updated successfully, but these errors were encountered: