Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fancy start tile on Windows (10 + possibly 8.1, would be nice to check). #2376

Merged
merged 1 commit into from
Jul 12, 2016
Merged

Fancy start tile on Windows (10 + possibly 8.1, would be nice to check). #2376

merged 1 commit into from
Jul 12, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits if needed.

Changes only affect Windows build / install / update.
Fixes #2372

@bsclifton
Copy link
Member Author

bsclifton commented Jul 3, 2016

I tested fairly well locally... but I can't build the installer unfortunately due to not understanding how to handle the Authenticode certificate / password part.

The images (70x70 and 150x150) can be replaced at any time- most of the work in this PR is copying them from the ./res folder into the build folder. The install/update process (squirrel) will then copy the manifest file (which should be at the project root) into the parent folder (where Update.exe lives; which is important because this is what is linked to w/ the shortcut)

If folks already have this pinned to their start, they'll need to unpin/pin again for the new manifest to be cached by Windows

Changes only affect Windows build / install / update.
Fixes #2372
@bbondy
Copy link
Member

bbondy commented Jul 12, 2016

lgtm we'll test soon with a beta build. I'll merge for now.

@bbondy bbondy merged commit 91a78ae into brave:master Jul 12, 2016
@bbondy bbondy added this to the 0.11.1dev milestone Jul 12, 2016
@bsclifton bsclifton deleted the start-menu-tile branch July 14, 2016 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants