Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Shields menu cover entire browser view when clicked on view count #11878

Closed
srirambv opened this issue Nov 9, 2017 · 2 comments
Closed

Shields menu cover entire browser view when clicked on view count #11878

srirambv opened this issue Nov 9, 2017 · 2 comments
Assignees
@luixxiul
Labels
0.20.x issue first seen in 0.20.x bug feature/shields QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Nov 9, 2017 •
edited by luixxiul
Loading

Test plan

#11880 (comment)

Description

Shields menu cover entire browser view when clicked on view count

Steps to Reproduce

  1. Build from Adds media publishers support #11727
  2. Visit YouTube and view couple of videos
  3. Click on shields, expand the adblock count to see details
  4. Shields menu covers 90% of the browser window. Doesn't happen on when shields is set to compact view

Actual result:
Normal Shields menu
image
Compact Shields menu
image

Expected result:
Shields should not cover the browser window

Reproduces how often:
Consistently on that PR. was able to see it on two different profile

Brave Version

about:brave info:

Brave 0.22.0
V8 6.2.414.36
rev 145f454
Muon 4.5.14

Reproducible on current live release:
No

Additional Information

cc: @luixxiul @bradleyrichter
@srirambv srirambv added this to the 0.22.x (Nightly Channel) milestone Nov 9, 2017
@luixxiul luixxiul self-assigned this Nov 9, 2017
@luixxiul luixxiul mentioned this issue Nov 9, 2017
Merged
8 tasks
@bbondy bbondy modified the milestones: 0.22.x (Nightly Channel), Triage Backlog Nov 9, 2017
@srirambv srirambv modified the milestones: 0.22.x (Nightly Channel), Triage Backlog Nov 9, 2017
@srirambv
Copy link
Collaborator Author

srirambv commented Nov 9, 2017

Happens on 0.20.x and 0.21.x as well. Marking as triage backlog

@luixxiul
Copy link
Contributor

Regression by #10489

@luixxiul luixxiul added 0.20.x issue first seen in 0.20.x and removed 0.22.x issue first seen in 0.22.x labels Nov 10, 2017
@luixxiul luixxiul modified the milestones: Triage Backlog, 0.20.x (Beta Channel) Nov 18, 2017
srirambv pushed a commit that referenced this issue Nov 20, 2017
@luixxiul @srirambv
Fix wide bravery panel to stop covering the webview (#11880)
21fba11 
* Set braveryPanel list width to zero

Fixes #11878

Auditors:

Test Plan:
1. Open https://chiebukuro.yahoo.co.jp/
2. Click the adblock count
3. Make sure panel width does not change

* Avoid a very long domain name from covering the webview

Auditors:

Test Plan:
1. Open https://longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com/
2. Open the wide bravery panel
3. Make sure the panel does not cover the webview
NejcZdovc pushed a commit that referenced this issue Nov 20, 2017
@luixxiul @NejcZdovc
Fix wide bravery panel to stop covering the webview (#11880)
f40134a 
* Set braveryPanel list width to zero

Fixes #11878

Auditors:

Test Plan:
1. Open https://chiebukuro.yahoo.co.jp/
2. Click the adblock count
3. Make sure panel width does not change

* Avoid a very long domain name from covering the webview

Auditors:

Test Plan:
1. Open https://longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com/
2. Open the wide bravery panel
3. Make sure the panel does not cover the webview
srirambv pushed a commit that referenced this issue Nov 20, 2017
@luixxiul @srirambv
Fix wide bravery panel to stop covering the webview (#11880)
e031461 
* Set braveryPanel list width to zero

Fixes #11878

Auditors:

Test Plan:
1. Open https://chiebukuro.yahoo.co.jp/
2. Click the adblock count
3. Make sure panel width does not change

* Avoid a very long domain name from covering the webview

Auditors:

Test Plan:
1. Open https://longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com/
2. Open the wide bravery panel
3. Make sure the panel does not cover the webview
This was referenced Dec 20, 2017
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
0.20.x issue first seen in 0.20.x bug feature/shields QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@bbondy @kjozwiak @luixxiul @srirambv @LaurenWags