Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Fix wide bravery panel to stop covering the webview (#11880)
Browse files Browse the repository at this point in the history
* Set braveryPanel list width to zero

Fixes #11878

Auditors:

Test Plan:
1. Open https://chiebukuro.yahoo.co.jp/
2. Click the adblock count
3. Make sure panel width does not change

* Avoid a very long domain name from covering the webview

Auditors:

Test Plan:
1. Open https://longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com/
2. Open the wide bravery panel
3. Make sure the panel does not cover the webview
  • Loading branch information
luixxiul authored and NejcZdovc committed Nov 20, 2017
1 parent 225c213 commit f40134a
Showing 1 changed file with 11 additions and 6 deletions.
17 changes: 11 additions & 6 deletions app/renderer/components/main/braveryPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,12 @@ const displayHost = {
fontWeight: 'normal',
textOverflow: 'ellipsis',
whiteSpace: 'nowrap',
overflow: 'hidden'
overflow: 'hidden',

// See #11878: avoid a very long domain drom covering the webview.
// The value should maintain the panel width until 0.19.
// https://github.com/brave/browser-laptop/blob/0.19.x/app/renderer/components/main/braveryPanel.js#L708
maxWidth: '320px'
}
const editGlobalMarginBottom = '.25rem'

Expand Down Expand Up @@ -911,7 +916,11 @@ const styles = StyleSheet.create({
braveryPanel__body__ul__li: {
listStyleType: 'none',
padding: '10px 0',
cursor: 'text'
cursor: 'text',

// #9839 and #11878: Avoid the panel width from increasing.
width: 0,
whiteSpace: 'nowrap'
},
braveryPanel__body__hr: {
background: globalStyles.braveryPanel.body.hr.background,
Expand Down Expand Up @@ -964,10 +973,6 @@ const styles = StyleSheet.create({
braveryPanel_compact__body__ul__li: {
padding: '5px 0',

// #9839: Avoid the panel width from increasing
width: 0,
whiteSpace: 'nowrap',

':first-of-type': {
paddingTop: 0
},
Expand Down

0 comments on commit f40134a

Please sign in to comment.