Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes ads are not shown due to round-robin not removing seen advertisers and/or ads - 1.27.x #9593

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Fixes ads are not shown due to round-robin not removing seen advertisers and/or ads - 1.27.x #9593

merged 1 commit into from
Aug 2, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jul 29, 2021 •
edited by kjozwiak
Loading

Uplift of #9571
Resolves brave/brave-browser#17199

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey requested a review from a team July 29, 2021 17:22
@tmancey tmancey self-assigned this Jul 29, 2021
@tmancey tmancey added this to the 1.27.x - Release #3 milestone Jul 29, 2021
@tmancey tmancey force-pushed the issues/17199-1.27.x branch from 5d57ed4 to d73f953 Compare July 29, 2021 19:20
kjozwiak
kjozwiak approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.27.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #9571 (comment).

@kjozwiak kjozwiak merged commit 105aa6f into 1.27.x Aug 2, 2021
@kjozwiak kjozwiak deleted the issues/17199-1.27.x branch August 2, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.27.x - Release #3
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak