-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ads are not shown due to round-robin not removing seen advertisers and/or ads #17199
Comments
This also resolves #15166 cc @btlechowski |
you're a hero, Sir @tmancey - many thanks. |
Verification passed on
Verified test plan below Test Plan
Expected:
Reproduced the issue in 1.27.109 First ad was shown
2nd ad was blocked. Round robin failed
Verified ad is shown after round robin Ad was shown
ad was shown again. round robin worked
Verified
Steps:
Confirmed 1st ad was shown:
Confirmed ad was shown again after round robin selection:
Verification PASSED on
Reproduced the original issue using Reproduced original issue
Using First Ad Shown
Second Ad Shown after 1hr
|
Description
Ads are not shown due to round-robin not removing seen advertisers and/or ads if the catalog contains split test groups that the user does not belong to (see above description).
Steps to Reproduce
Actual result:
Ad notification was not delivered
Expected result:
Ad notification should be delivered
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: