Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Brave Search name (uplift to 1.26.x) #9226

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Update Brave Search name (uplift to 1.26.x) #9226

merged 1 commit into from
Jun 29, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jun 23, 2021 •
edited by kjozwiak
Loading

Uplift of #9216
Fixes brave/brave-browser#16564

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team June 23, 2021 23:10
@brave-builds brave-builds self-assigned this Jun 23, 2021
@brave-builds brave-builds added this to the 1.26.x - Release #2 milestone Jun 23, 2021
@bsclifton bsclifton force-pushed the pr9216_bsc-rename-brave-search_1.26.x branch from e3f14a5 to 46ed28f Compare June 28, 2021 18:57
@bsclifton bsclifton force-pushed the pr9216_bsc-rename-brave-search_1.26.x branch from 46ed28f to bc2459d Compare June 28, 2021 19:36
kjozwiak
kjozwiak approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.26.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per brave/brave-browser#16564 (comment).

@kjozwiak kjozwiak merged commit d232719 into 1.26.x Jun 29, 2021
@kjozwiak kjozwiak deleted the pr9216_bsc-rename-brave-search_1.26.x branch June 29, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.26.x - Release #3
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases