relabel search engine name to "Brave"

[rebron]

Description

We currently have search engine name set as Brave Search beta but the label looks awkward when searching from the url bar.

Search engine name should just be Brave and searches from url bar should show [query] - Brave Search

Steps to Reproduce

1. Download 1.26.67.
2. Change default search engine to Brave Search beta from brave://settings/search
3. Perform a search and notice [query] - Brave Search beta Search

Actual result:

Expected result:

When searching from URL bar -

Manage Settings drop down -

Other Search engines list -

Reproduces how often:

Easily.

Brave version (brave://version info)

1.26.67

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

[stephendonner]

Verified PASSED using

Brave	1.26.73 Chromium: 91.0.4472.124 (Official Build) (x86_64)
Revision	7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS	macOS Version 11.4 (Build 20F71)

Went through two scenarios re: upgrading from 1.26.67 --> 1.26.73 Chromium: 91.0.4472.124.

• Scenario #1: Brave Search isn't set as the default
• Scenario #2: Brave Search is set as the default

Ensured that the correct text/labels were being used for the two above scenarios. Also ensured that previously selected search engines stay as default after upgrading.

• Scenario #1: Brave Search isn't set as the default and upgraded to 1.26.73 Chromium: 91.0.4472.124

Example	Example	Example	Example	Example	Example

• Scenario #2: Brave Search is set as the default and upgraded to 1.26.73 Chromium: 91.0.4472.124

Example	Example	Example	Example	Example	Example	Example

---

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.28.34 Chromium: 91.0.4472.124 (Official Build) nightly (64-bit)
--- | ---
Revision | 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS | Windows 10 OS Version 2009 (Build 19042.1081)

Went through two scenarios re: upgrading from 1.28.23 Chromium: 91.0.4472.114 --> 1.28.34 Chromium: 91.0.4472.124.

• Scenario #1: Brave Search isn't set as the default
• Scenario #2: Brave Search is set as the default

Ensured that the correct text/labels were being used for the two above scenarios. Also ensured that previously selected search engines stay as default after upgrading.

• Scenario #1: Brave Search isn't set as the default and upgraded to 1.28.34 Chromium: 91.0.4472.124

Example	Example	Example	Example	Example

• Scenario #2: Brave Search is set as the default and upgraded to 1.28.34 Chromium: 91.0.4472.124

Example	Example	Example	Example

---

Verification PASSED on Samsung S10+ running Android 11 using the following build:

Brave | 1.28.34 Chromium: 91.0.4472.124

Test Case #1 (Default Install)

Example	Example	Example

Test Case #2 (Update & Brave Search not default SE)

Upgraded from 1.28.22 Chromium: 91.0.4472.114 --> 1.28.34 Chromium: 91.0.4472.124 and ensured that Brave was being used instead of Brave Search beta. Also ensured that the previous default SE hasn't been changed.

Example	Example

Test Case #3 (Update & Brave Search is set as default SE)

Upgraded from 1.28.22 Chromium: 91.0.4472.114 --> 1.28.34 Chromium: 91.0.4472.124 and ensured that Brave was being used instead of Brave Search beta.

Example	Example	Example

[kjozwiak]

@brave/legacy_qa note that seeing Brave Search beta being displayed after upgrading on Android is expected as per:

[kjozwiak]

Clearing QA Pass-macOS so we can make sure the above is working correctly once we get 1.26.x RC's as Brave Search is pretty important 👍

[GeetaSarvadnya]

Verification passed on

Brave | 1.26.73 Chromium: 91.0.4472.124 (Official Build) (64-bit)
-- | --
Revision | 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS | Windows 10 OS Version 2004 (Build 19041.1052)

Went through two scenarios re: upgrading from 1.26.67 --> 1.26.73 Chromium: 91.0.4472.124.

• Scenario #1: Brave Search isn't set as the default
• Scenario #2: Brave Search is set as the default

Ensured that the correct text/labels were being used for the two above scenarios. Also ensured that previously selected search engines stay as default after upgrading.

• Scenario #1: Brave Search isn't set as the default and upgraded to 1.26.73 Chromium: 91.0.4472.124

1.26.67	1.26.67	1.26.67	1.26.73	1.26.73	1.26.73

• Scenario #2: Brave Search is set as the default and upgraded to 1.26.73 Chromium: 91.0.4472.124

1.26.67	1.26.73	1.26.73	1.26.73	1.26.73	1.26.73

---

Verified passed with

Brave	1.26.73 Chromium: 91.0.4472.124 (Official Build) (64-bit)
Revision	7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS	Linux

Scenario 1: Clean install of 1.26.73

Confirmed expected text/labels displayed in below areas.

Example	Example	Example	Example	Example	Example	Example	Example

Scenario 2: Upgrade from 1.26.67 (Brave Search is not default SE)

Confirmed expected text/labels displayed in below areas. Confirmed previously set default SE remained default SE. Screenshots from 1.26.67 for comparison.

1.26.67	1.26.73

Also confirmed in this case that if you change default SE to Brave after upgrading, expected text shows in URL bar:

Scenario 3: Upgrade from 1.26.67 (Brave Search is default SE)

Confirmed expected text/labels displayed in below areas. Confirmed previously set default SE remained default SE. Screenshots from 1.26.67 for comparison.

1.26.67	1.26.73

[srirambv]

Verification passed on OnePlus 6T with Android 10 running 1.26.74 x64 build
Clean Install

• Verified Brave Search beta is updated to Brave during onboarding
• Verified selecting Brave during onboarding sets it as default for both normal and private tabs

**Upgrade Install (with Brave as default)

• Verified upgrading to 1.26.74 updates the Search engine name for both standard and private tabs in selection view
• Verified upgrading to 1.26.74 retains Brave Search beta on Search engines overview page

Upgrade Install (with Brave not set as default)

• Verified upgrading retains the SE list correctly and default SE
• Verified upon upgrade Brave Search beta is replaced by Brave for both standard and private tabs in selection view

---

Verification passed on Samsung Tab A with Android 10 running 1.26.74 x64 build
Clean Install

• Verified Brave Search beta is updated to Brave during onboarding
• Verified selecting Brave during onboarding sets it as default for both normal and private tabs

**Upgrade Install (with Brave as default)

• Verified upgrading to 1.26.74 updates the Search engine name for both standard and private tabs in selection view
• Verified upgrading to 1.26.74 retains Brave Search beta on Search engines overview page

Upgrade Install (with Brave not set as default)

• Verified upgrading retains the SE list correctly and default SE
• Verified upon upgrade Brave Search beta is replaced by Brave for both standard and private tabs in selection view