-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom conversion ID patterns for Verifiable Advertiser Conversions #8640
Conversation
4a66093
to
96c1994
Compare
To increase adoption of Verifiable Advertiser Conversions we provide a mechanism to extract a conversion ID from an advertiser's conversion site w/o the need to modify its DOM. To this end a regex pattern can be configured via the conversions resource to extract the ID from either the URL or the DOM. The default pattern has been made configurable via griffin.
96c1994
to
978142a
Compare
"search_in": "url" | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline at end of file, otherwise github complains, see above
ConversionIdPatternMap conversion_id_patterns = resource.get(); | ||
|
||
// Assert | ||
EXPECT_EQ(2u, conversion_id_patterns.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: 2U
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
Resolves brave/brave-browser#15491
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
VAC - DOM
Conversion ID: foo-12345
VAC - URL
Conversion ID: baz-987-xyz
VAC files.zip