Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing conversionEnvelope on ios conversions for Verifiable Ad Conversion #19943

Closed
iambrianfung opened this issue Dec 6, 2021 · 1 comment
Assignees
Labels
bug closed/duplicate Issue has already been reported feature/ads

Comments

@iambrianfung
Copy link
Collaborator

iambrianfung commented Dec 6, 2021

Verifiable Ad Conversions do not seem to be working consistently on iOS.

Originally thought to be due to slow upgrades but example A. is a fresh campaign that only started after ios was supposed to be supported.

All ios conversions are missing conversion envelope
Example A.

Some ios conversions have conversionEnvelope
Example B.
Use link from above but replace WHERE clause with
WHERE ads_aurora.campaign_redshift_staging.campaign_id in ('04d01606-3bf2-41d9-afa2-54408159ed43', '1056f376-67d3-49dd-a255-f0854f1c4907')

Testing

Set settings to US-geo.

1. DOM

Confirm staging catalog contains the following creativeInstanceId

VAC DOM:
creativeInstanceId: de8274a9-716b-4340-afa1-9bfa52289077
Conversion URL: https://brave.com/?vac=*

Map locally page.html from .zip file in brave/brave-core#8640
Force Ad for creativeInstanceId
Go to conversion URL: https:brave.com/?vac=DOM
Confirm that conversion ID is extracted into conversion queue table
Confirm that conversionEnvelope is generated and sent in ads confirmation

2. URL

Confirm staging catalog contains the following creativeInstanceId

VAC URL:
creativeInstanceId: 0e3fa44c-edd4-4ad3-b21e-e6c93ef001c4
Conversion URL: https://*.nytimes.com/section/world?conversion_id=*

Force Ad for creativeInstanceId
Go to conversion URL: https://www.nytimes.com/section/world?conversion_id=tm-<insert_value>
Confirm that conversion ID is extracted into conversion queue table
Confirm that conversionEnvelope is generated and sent in ads confirmation

Confirm with @iambrianfung that these confirmations are in the staging ads database

@iambrianfung iambrianfung added needs-investigation A bug not 100% confirmed/fixed feature/ads labels Dec 6, 2021
@iambrianfung iambrianfung changed the title Verifiable Ad Conversion on ios missing conversionEnvelope on ios conversions for Verifiable Ad Conversion Dec 6, 2021
@jsecretan jsecretan added the bug label Dec 14, 2021
@tmancey tmancey self-assigned this Jan 19, 2022
@tmancey
Copy link
Contributor

tmancey commented Jan 28, 2022

Closing issue as duplicate of brave/brave-ios#4914

@tmancey tmancey closed this as completed Jan 28, 2022
@tmancey tmancey added closed/duplicate Issue has already been reported and removed needs-investigation A bug not 100% confirmed/fixed labels Jan 28, 2022
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/duplicate Issue has already been reported feature/ads
Projects
Archived in project
Development

No branches or pull requests

3 participants