Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 89.0.4389.114 to Chromium 89.0.4389.128 (1.22.x). #8531

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Apr 13, 2021

Fixes brave/brave-browser#15270
Related PR: brave/brave-browser#15271

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added CI/skip-windows CI/skip-ios Do not run CI builds for iOS labels Apr 14, 2021
@mkarolin mkarolin force-pushed the 89.0.4389.128_1.22.x_91 branch from 3d301e0 to 8e21b9a Compare April 14, 2021 04:05
@mkarolin
Copy link
Collaborator Author

CI passed on Windows, Linux, and iOS.
CI timed out on Mac.

Rebased branch to pick up goma changes for Android.
Rerunning CI for Mac and Android only,

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

post-init failed audit-deps as per https://ci.brave.com/job/pr-brave-browser-89.0.4389.128_1.22.x_91-post-init/3/execution/node/144/log/. This was a known failure/warning and was fixed on all other channels. 1.22.x never received the uplift/fix. Unrelated to this specific PR.

@kjozwiak kjozwiak added this to the 1.22.x - Release #6 milestone Apr 14, 2021
@kjozwiak
Copy link
Member

Approving & Merging into 1.22.x as both @bsclifton & @bbondy approved 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants