Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 89.0.4389.114 to Chromium 89.0.4389.128 (1.22.x). #15270

Closed
mkarolin opened this issue Apr 13, 2021 · 3 comments
Closed

Upgrade from Chromium 89.0.4389.114 to Chromium 89.0.4389.128 (1.22.x). #15270

mkarolin opened this issue Apr 13, 2021 · 3 comments
Assignees
@mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.22.x - Release #6

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/89.0.4389.114..89.0.4389.128?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).
@mkarolin mkarolin added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Apr 13, 2021
@mkarolin mkarolin self-assigned this Apr 13, 2021
This was referenced Apr 13, 2021
Merged
Merged
@kjozwiak kjozwiak added this to the 1.22.x - Release #6 milestone Apr 14, 2021
@LaurenWags
Copy link
Member

Closing issue as this was merged via #15271 and brave/brave-core#8531

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 14, 2021 •
edited by btlechowski
Loading

Verification passed on


Brave | 1.22.72 Chromium: 89.0.4389.128 (Official Build) (64-bit)
-- | --
Revision | 6d949d51e94419a5014d249141019d8bffc75f69-refs/branch-heads/4389@{#1640}
OS | Windows 10 OS Version 2004 (Build 19041.867)

image

Verified passed with

Brave	1.22.72 Chromium: 89.0.4389.128 (Official Build) (arm64)
Revision	6d949d51e94419a5014d249141019d8bffc75f69-refs/branch-heads/4389@{#1640}
OS	macOS Version 11.2.3 (Build 20D91)

arm64

Verified passed with

Brave | 1.22.72 Chromium: 89.0.4389.128 (Official Build) (x86_64)
-- | --
Revision | 6d949d51e94419a5014d249141019d8bffc75f69-refs/branch-heads/4389@{#1640}
OS | macOS Version 10.15.7 (Build 19H524)

x64

Verification passed on

Brave 1.22.72 Chromium: 89.0.4389.128 (Official Build) (64-bit)
Revision 6d949d51e94419a5014d249141019d8bffc75f69-refs/branch-heads/4389@{#1640}
OS Ubuntu 18.04 LTS

image

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.22.72 x64 build

OnePlus 6T (Android 10) Samsung Tab A (Android 10)

This was referenced Apr 14, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.22.x - Release #6
Development

No branches or pull requests
6 participants
@kjozwiak @srirambv @LaurenWags @btlechowski @GeetaSarvadnya @mkarolin