Fixed crash when searching from omnibox in tor window with search engine extension

[simonhong]

fix brave/brave-browser#15140

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[bridiver]

see comments

[iefremov]

cc @mariospr

[kjozwiak]

@simonhong seems like this is still still crashing using 1.25.8 CR: 90.0.4430.61 which should have the above fix. Example of the crashes:

• Uploaded crash report ID: 86180000-9cfd-2306-0000-000000000000
• Uploaded crash report ID: 85180000-9cfd-2306-0000-000000000000
• Uploaded crash report ID: 87180000-9cfd-2306-0000-000000000000

STR:

• install DDG privacy essentials via https://chrome.google.com/webstore/detail/duckduckgo-privacy-essent/bkdgflcldnnnapblkhphbgpggdiikppg?hl=en
• on brave://extensions/?id=bkdgflcldnnnapblkhphbgpggdiikppg enable "Allow in private"
• open TOR window
• wait till it's finished initializing/downloading the Tor component
• enter brave browser into the omnibox and click Enter
• instant crash

I can reproduce 100% of the time on my Win 10 x64 machine.

[kjozwiak]

Created brave/brave-browser#15224 as the above is a different crash and requires actually searching. The above fixes the crash when a user sets focus in the URL.

[kjozwiak]

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.25.10 Chromium: 90.0.4430.61 (Official Build) nightly (64-bit)
-- | --
Revision | dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115}
OS | Windows 10 OS Version 2009 (Build 19042.906)

• verified that Brave doesn't crash when running through the cases outlined via Crash while using omnibox in Tor window with an enabled extension brave-browser#15140 (comment)
• ensured that Brave doesn't crash when typing into the omnibox within a Tor window
• ensured that Brave doesn't crash when typing into the omnibox within a Private window

However, brave/brave-browser#15224 is still happening and will need to be fixed in a new PR.