crash when searching via private window while having SE extension set as Allow in private

[kjozwiak]

Description

When you have a SE extension installed and have set it as Allow in Private, searching for a term via private mode will crash the entire browser. Similar to the issue that was fixed via #15140.

• Uploaded crash report ID: d5250000-9cfd-2306-0000-000000000000
• Uploaded crash report ID: d4250000-9cfd-2306-0000-000000000000
• Uploaded crash report ID: d3250000-9cfd-2306-0000-000000000000

Steps to Reproduce

1. download https://chrome.google.com/webstore/detail/duckduckgo-privacy-essent/bkdgflcldnnnapblkhphbgpggdiikppg/related?hl=en
2. go into brave://extensions and set DDG Privacy Essentials as Allow in private by clicking Details
3. open a private window and type in test test and click enter to start the search
4. instant crash

Actual result:

Brave instantly crashes.

Expected result:

Brave shouldn't be crashing.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave | 1.23.69 Chromium: 90.0.4430.61 (Official Build) (64-bit)
-- | --
Revision | dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115}
OS | Windows 10 OS Version 2009 (Build 19042.906)

Brave | 1.25.8 Chromium: 90.0.4430.61 (Official Build) nightly (64-bit)
-- | --
Revision | dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115}
OS | Windows 10 OS Version 2009 (Build 19042.906)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @bsclifton @simonhong @brave/legacy_qa

[bsclifton]

Likely related to #10601 and #10549

[kjozwiak]

This isn't a new regression, @simonhong mentioned that he can reproduce the crash in 1.22.x and I also managed to reproduce using the following build:

Brave | 1.22.71 Chromium: 89.0.4389.114 (Official Build) (64-bit)
-- | --
Revision | 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS | Windows 10 OS Version 2009 (Build 19042.906)

Probably not a release/blocking as it's already on Release, but something we should probably fix sooner than later as crashes are never good.

[GeetaSarvadnya]

Reproduced the issue in Windows 10 x64

Brave | 1.23.70 Chromium: 90.0.4430.70 (Official Build) (64-bit)
-- | --
Revision | 3954de7175366f3b7edca576f140dfa273e6b5ae-refs/branch-heads/4430@{#1210}
OS | Windows 10 OS Version 2004 (Build 19041.867)

and

Brave | 1.22.71 Chromium: 89.0.4389.114 (Official Build) (64-bit)
-- | --
Revision | 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS | Windows 10 OS Version 2004 (Build 19041.867)

[stephendonner]

Verified FIXED using the inline testplan with build

Brave	1.26.22 Chromium: 91.0.4472.57 (Official Build) nightly (x86_64)
Revision	e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS	macOS Version 11.3.1 (Build 20E241)

Steps:

1. downloaded and installed DuckDuckGo Privacy Essentials from https://chrome.google.com/webstore/detail/duckduckgo-privacy-essent/bkdgflcldnnnapblkhphbgpggdiikppg/related?hl=en
2. went into brave://extensions, clicked on Details for DDG Privacy Essentials, and toggled Allow in private to On
3. opened File -> New Private Window and type in test test and click enter/return to start the search
4. confirmed I no longer crash (tried 10x); instead, I got the search-results page, as expected

step 1	step 2	step 3	step 4

---

Verification passed on

<!--StartFragment-->
Brave | 1.26.43 Chromium: 91.0.4472.77&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->

• Verified the STR from crash when searching via private window while having SE extension set as Allow in private #15224 (comment)
• Ensured there is no crash in PT/TOR/Guest when test test string is typed in the Omnibox and hit enter

---

Verification passed on

Brave	1.26.45 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision	1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS	Ubuntu 18.04 LTS

• Verified the STR from crash when searching via private window while having SE extension set as Allow in private #15224 (comment)
• Ensured there is no crash in PT/TOR/Guest when test test string is typed in the Omnibox and hit enter

[btlechowski]

Added QA/Test-All-Platforms as Tor is using different binaries for each platform

[LaurenWags]

Testing brave/brave-core#8626 will cover the following issues:

• crash when searching via private window while having SE extension set as Allow in private #15224 (this issue)
• Search Engines added by Extensions unavailable in Private Window #10601
• Crash in settings_overridden_params::GetSearchOverriddenParams #14218