Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable re-linking when a user connects an Uphold wallet (uplift to 1.22.x) #8211

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Enable re-linking when a user connects an Uphold wallet (uplift to 1.22.x) #8211

merged 1 commit into from
Mar 18, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 10, 2021 •
edited by kjozwiak
Loading

Uplift of #8180
Resolves brave/brave-browser#14573

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team March 10, 2021 21:03
@brave-builds brave-builds self-assigned this Mar 10, 2021
@brave-builds brave-builds added this to the 1.22.x - Beta milestone Mar 10, 2021
kjozwiak
kjozwiak approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.22.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8180 (comment) & https://github.com/brave/brave-core/pull/8180#issuecomment-801886339https://github.com/brave/brave-core/pull/8180#issuecomment-801886339.

@kjozwiak kjozwiak merged commit 730bac6 into 1.22.x Mar 18, 2021
@kjozwiak kjozwiak deleted the pr8180_ksmith-uphold-relinking_1.22.x branch March 18, 2021 15:14
@kjozwiak kjozwiak mentioned this pull request Mar 18, 2021
Closed
tmancey pushed a commit that referenced this pull request Oct 25, 2023
@kylehickinson
Fix #8211: Remove the dislike swipe action on ads (#8304)
4b787db 
This also cleans up and removes the unused open swipe action and accompanying pan gesture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.22.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases