Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt Uphold wallet relinking more often #14573

Closed
zenparsing opened this issue Mar 8, 2021 · 3 comments · Fixed by brave/brave-core#8180
Closed

Attempt Uphold wallet relinking more often #14573

zenparsing opened this issue Mar 8, 2021 · 3 comments · Fixed by brave/brave-core#8180

Comments

@zenparsing
Copy link

Currently, Rewards will attempt to link the user's Uphold wallet to their payment ID only once for the user's profile. Instead, we should attempt to re-link the user's Uphold wallet when they successfully complete the Uphold login process.

@LaurenWags
Copy link
Member

labelling as QA/Blocked until this is uplifted to 1.22.x and a new build is created

@kjozwiak
Copy link
Member

Merged into 1.22.x via brave/brave-core#8211 (review). Just need a new build which we'll get soon. Still waiting on one more PR.

@srirambv
Copy link
Contributor

srirambv commented Mar 19, 2021

Verification passed on OnePlus 6T with Android 10 running 1.22.65 x64 build

  • Verified disconnecting an existing wallet shows up on log
2021-03-19 08:37:33.213 6242-6242/? V/chromium: [VERBOSE1:uphold.cc(196)] Disconnecting wallet
  • Verified reconnecting wallet shows the confirmation of existing wallet
2021-03-19 08:39:37.495 6242-6242/? V/chromium: [VERBOSE1:wallet_create.cc(35)] Wallet already exists
2021-03-19 08:39:37.502 6242-6242/? V/chromium: [VERBOSE5:ledger_impl.cc(133)] 
    [ REQUEST ]
    > URL: https://api-sandbox.uphold.com/oauth2/token
    > Method: UrlMethod::POST
    > Content: code=44..................&grant_type=authorization_code
    > Content Type: application/x-www-form-urlencoded
2021-03-19 08:34:21.836 6242-6242/? V/chromium: [VERBOSE5:ledger_impl.cc(133)] 
    [ REQUEST ]
    > URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/7ba............................./claim
    > Method: UrlMethod::POST
    > Content: {"signedLinkingRequest":"eyJ.........."}
    > Content Type: application/json; charset=utf-8
  • Verified able to reconnect/relink from panel as well
2021-03-19 08:43:07.550 6242-6242/? V/chromium: [VERBOSE6:logging_util.cc(136)] 
    [ RESPONSE - OnRequest ]
    > Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/7ba.............................../claim
    > Result: Success
    > HTTP Code: 200
    > Body: null
Disconnected Connected
image image

Verified passed with

Brave	1.22.65 Chromium: 89.0.4389.90 (Official Build) (x86_64)
Revision	62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS	macOS Version 10.15.7 (Build 19H524)

Verified test plan from brave/brave-core#8180

After disconnecting the wallet, I saw the below in my logs:

[Mar 19, 2021, 11:41:12.4 AM:INFO:uphold.cc(196)] Disconnecting wallet

Confirmed UI showed wallet as disconnected:

brave://rewards brave://rewards-internals panel
Rewards internals panel

Reconnected Uphold wallet on brave://rewards:

brave://rewards brave://rewards-internals panel
Rewards2 internals2 panel2

Confirmed I see linking request in the logs:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/f0............0/claim
> Method: UrlMethod::POST
> Content: {"signedLinkingRequest":"eyJ.............
> Content Type: application/json; charset=utf-8
[Mar 19, 2021, 11:43:32.8 AM:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/f0.............0/claim
> Result: Success
> HTTP Code: 200
> Body: null

Checked able to reconnect/relink from panel as well:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/f0.............0/claim
> Method: UrlMethod::POST
> Content: {"signedLinkingRequest":"eyJ.............
> Content Type: application/json; charset=utf-8
[Mar 19, 2021, 11:45:49.5 AM:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/f0................0/claim
> Result: Success
> HTTP Code: 200
> Body: null

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants