Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Today: do not limit history search to the default of 100 items #7335

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

petemill
Copy link
Member

@petemill petemill commented Dec 4, 2020

Resolves brave/brave-browser#13041

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@petemill petemill self-assigned this Dec 4, 2020
@petemill petemill requested review from bsclifton and ryanml December 4, 2020 00:06
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ LGTM

@petemill petemill merged commit ab1e62c into master Dec 8, 2020
@petemill petemill deleted the today-fix-history-search branch December 8, 2020 19:07
petemill added a commit that referenced this pull request Dec 8, 2020
Brave Today: do not limit history search to the default of 100 items
@bsclifton bsclifton added this to the 1.20.x - Nightly milestone Dec 8, 2020
kjozwiak added a commit that referenced this pull request Dec 9, 2020
1.19.x: Uplift pull request #7335 from brave/today-fix-history-search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave Today history scoring should not be limited to 100 items
2 participants