Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Today history scoring should not be limited to 100 items #13041

Closed
petemill opened this issue Dec 4, 2020 · 0 comments · Fixed by brave/brave-core#7335
Closed

Brave Today history scoring should not be limited to 100 items #13041

petemill opened this issue Dec 4, 2020 · 0 comments · Fixed by brave/brave-core#7335
Assignees
@petemill
Labels
feature/brave-news formerly brave-today OS/Desktop QA/No release-notes/include
Milestone
1.19.x - Release

Comments

@petemill
Copy link
Member

petemill commented Dec 4, 2020 •
edited
Loading

The intention of Brave Today's scoring of items was to consider the last 2 weeks of history items. However, without specifying a maxResults in the chrome.history.search API call, we are limited to 100 items. We should specify a maxResults of 2000 items.

I'd say the testing / QA of this isn't really neccessary because it's obvious what the call is doing from the code, and manual testing would be very annoying and prone to false negatives:

  1. Fresh profile
  2. Visit the second item in the Brave Today feed, as long as it's not the same publisher source as the first item.
  3. Visit 101 more sites.
  4. Generate a new Brave Today feed by disabling a publisher source that is not the first or second item.
    --> Observe that the item which was 2nd is now 1st.
@petemill petemill added OS/Desktop feature/brave-news formerly brave-today labels Dec 4, 2020
@petemill petemill self-assigned this Dec 4, 2020
@petemill petemill mentioned this issue Dec 4, 2020
Merged
23 tasks
@rebron rebron changed the title [Desktop] Brave Today history scoring is limited to 100 items Brave Today history scoring is limited to 100 items Dec 7, 2020
@petemill petemill mentioned this issue Dec 8, 2020
Merged
@petemill petemill changed the title Brave Today history scoring is limited to 100 items Brave Today history scoring should not be limited to 100 items Dec 8, 2020
@bsclifton bsclifton added this to the 1.20.x - Nightly milestone Dec 8, 2020
@kjozwiak kjozwiak mentioned this issue Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
feature/brave-news formerly brave-today OS/Desktop QA/No release-notes/include
Projects
None yet
Milestone
1.19.x - Release
Development

Successfully merging a pull request may close this issue.

Brave Today: do not limit history search to the default of 100 items brave/brave-core
3 participants
@petemill @kjozwiak @bsclifton