Fix incognito icon in cookie settings

[mherrmann]

Fixes: brave/brave-browser#11738

@mihaiplesa can you suggest additional reviewers?

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint, npm run gn_check)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Requested a security/privacy review as needed.
• Added appropriate QA labels (QA/Yes or QA/No) to the associated issue
• Added appropriate release note labels (release-notes/include or release-notes/exclude) to the associated issue
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[mherrmann]

The Linux build failure seems to be unrelated to this PR. I tried the generated .deb and am getting the expected UI change:

[mihaiplesa]

That icon looks familiar, wonder if we already had it added and we can just reference it.

[mherrmann]

I did a preliminary search for the existing icon while researching the fix. Will try again.

[mherrmann]

It's available as incognito.icon and incognito_profile.icon in vector_icons/chrome/app/vector_icons.

In words, the "Private" icons in this screenshot in Brave:

are produced by the .icon files above. Here are screenshots of these .icon files, generated with https://github.com/sadrulhc/vector-icons:

I am not sure whether we can reference .icon files in brave://settings. Do you know who we could ask @mihaiplesa?

[petemill]

Thanks for this, left some feedback that would result in not needing to patch.

[mherrmann]

Thank you very much for your kind review and suggestions @petemill @mkarolin. I implemented your recommended changes and still get the same screenshots:

I also verified that it uses the shorter SVG suggested by @petemill.

This is my first PR to brave-core. How should I proceed? For example, should I squash my commits, or rebase them onto the current master?

[petemill]

Looks perfect. Yes, please squash before merge if you are able.

You don't have to rebase on master as there are no conflicts and CI has passed enough steps apart from what seems like a transient error that IMO we can ignore.

Good to merge if your squash results in no code change.

[mherrmann]

Squashed and merged. Thank you @petemill @mkarolin @mihaiplesa !

[bsclifton]

🕶️