Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome incognito icon is used in allow cookies sites list #11738

Closed
GeetaSarvadnya opened this issue Sep 16, 2020 · 5 comments · Fixed by brave/brave-core#7074
Closed

Chrome incognito icon is used in allow cookies sites list #11738

GeetaSarvadnya opened this issue Sep 16, 2020 · 5 comments · Fixed by brave/brave-core#7074

Comments

@GeetaSarvadnya
Copy link

Description

chrome incognito icon is used in allow cookies sites list

Steps to Reproduce

  1. Open Brave 1.16.x or 1.14.x
  2. Visit brave://settings/cookies
  3. Open a PT window and visit any site
  4. Come back to brave://settings/cookies again
  5. chrome incognito icons are displayed under Sites that can always use cookies section

Actual result:

image

Expected result:

Brave branded icons should be displayed

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.16.19 Chromium: 86.0.4240.30 (Official Build) nightly (64-bit)
Revision 09f50eb5535879364cf00e72653462a509ef6bdc-refs/branch-heads/4240@{#552}
OS Windows 10 OS Version 1903 (Build 18362.1016)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron

@mihaiplesa
Copy link
Contributor

@brave/design @mherrmann will help us with this if you can point us to which icons to use.

@mherrmann
Copy link

We need a 20x20 SVG to replace the icon in the above screenshot.

@karenkliu
Copy link

Here you go!

private-mode.svg.zip

@mherrmann
Copy link

Thank you @karenkliu!

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Nov 19, 2020

Verification passed on


Brave | 1.18.57 Chromium: 87.0.4280.66 (Official Build) beta (64-bit)
-- | --
Revision | fd98a29dd59b36f71e4741332c9ad5bda42094bf-refs/branch-heads/4280@{#1432}
OS | Windows 10 OS Version 2004 (Build 19041.572)

  • Verified the STR from the description

Light mode:
image

Dark mode:
image


Verification passed on

Brave 1.18.62 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description

Light mode:
image

Dark mode:
image

@rebron rebron changed the title chrome incognito icon is used in allow cookies sites list Chrome incognito icon is used in allow cookies sites list Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants