Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue with auto rotate #6650

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Fix the issue with auto rotate #6650

merged 1 commit into from
Sep 15, 2020

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#11632

Submitter Checklist:

Test Plan:

Please follow the plan on the main issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Sep 15, 2020
@deeppandya deeppandya added this to the 1.16.x - Nightly milestone Sep 15, 2020
@deeppandya deeppandya self-assigned this Sep 15, 2020
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

Reproduced the original issue on Samsung S10+ running Android 10 using 1.13.87 CR: 85.0.4183.102 using the following STR:

  • disabled auto rotate via sliding the status bar down and expanding all available options
  • visited several websites and ensured device always used Portrait when rotating phone
  • tapped on the Privacy Report button under brave://newtab

Even though auto rotate is disabled, rotating switched it between Portrait & Landscape

Verified the above STR on Samsung S10+ running Android 10 using 1.16.20 CR: 86.0.4240.30. Also ensured the following:

  • ensured that Brave correctly rotates between portrait and landscape when auto rotate is enabled
  • ensured that Brave doesn't rotates between portrait and landscape when auto rotate is disabled
    • ensured that tapping on the Privacy Report button under brave://newtab doesn't cause any rotation issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Auto rotate is off but screen is rotating after 1.13.85 update
4 participants